Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionable Questing epub generation fails to load images #1112

Closed
Kiradien opened this issue Nov 13, 2023 · 1 comment
Closed

Questionable Questing epub generation fails to load images #1112

Kiradien opened this issue Nov 13, 2023 · 1 comment

Comments

@Kiradien
Copy link
Collaborator

Kiradien commented Nov 13, 2023

When generating an epub from any QQ thread with images in main content fails to load images. URI path to proxy is wrong. It adds full thread path before proxy.php instead of the root (/)

Generated path: https://questionablequesting.com/threads/battletech-the-ghost-who-walks-battletech-isekai.15094/proxy.php?image=https%3A%2F%2Fi.imgur.com%2FE3d9MOW.jpg&hash=7e1afdc066fb54cb44effe1939c8262e
Actual path: https://questionablequesting.com/proxy.php?image=https%3A%2F%2Fi.imgur.com%2FE3d9MOW.jpg&hash=7e1afdc066fb54cb44effe1939c8262e

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://questionablequesting.com/threads/battletech-the-ghost-who-walks-battletech-isekai.15094/'
  2. Click on 'Index'
  3. Open WebToEpub interface
  4. Select only "Part 1" and generate
  5. See error

Expected behavior
Generation is successful

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Google Chrome
  • Version 119.0.6045.124 (Official Build) (64-bit) (cohort: Stable)

Additional context
The issue is triggered by a simple uri issue when the source is defined. I have a simple solution that I will push to my own branch, but it might not be ideal.

@Kiradien
Copy link
Collaborator Author

Simple brute-force PR is up for this, doesn't resolve the source of the problem but eliminates its effects, at least on QQ.

dteviot added a commit that referenced this issue Nov 14, 2023
Fix #1112 - Fixed QQ image redirect issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant