Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

pre-commit: PR181709 - #3474

Closed
zyw-bot wants to merge 3 commits into
mainfrom
test-run22074258187
Closed

zyw-bot wants to merge 3 commits into
mainfrom
test-run22074258187

Conversation

@zyw-bot

@zyw-bot zyw-bot commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot mentioned this pull request Feb 16, 2026
@zyw-bot

zyw-bot commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator Author

Diff mode

runner: ariselab-64c-docker
baseline: llvm/llvm-project@f03ff95
patch: llvm/llvm-project#181709
sha256: 7703642bae0d8fbcb92d436d7ffd2d2c27df292d99c2dd536fc2dd414d026a6b
commit: 9f6a8b3

390 files changed, 669309 insertions(+), 671755 deletions(-)

Improvements:
  dse.NumRedundantStores 36266 -> 37079 +2.24%
  licm.NumPromotionCandidates 583595 -> 583653 +0.01%
  memdep.NumCacheDirtyNonLocalPtr 23031 -> 23033 +0.01%
  sccp.NumDeadBlocks 676128 -> 676157 +0.00%
  correlated-value-propagation.NumPhiCommon 52005 -> 52007 +0.00%
  simplifycfg.NumSinkCommonCode 377511 -> 377525 +0.00%
  simplifycfg.NumSinkCommonInstrs 826928 -> 826958 +0.00%
  gvn.IsValueFullyAvailableInBlockNumSpeculationsMax 602106 -> 602119 +0.00%
  indvars.NumElimCmp 51445 -> 51446 +0.00%
  capture-tracking.NumCapturedBefore 16174121 -> 16174366 +0.00%
Regressions:
  dse.NumCFGTries 56378 -> 56356 -0.04%
  bdce.NumRemoved 379111 -> 379031 -0.02%
  correlated-value-propagation.NumSelects 228013 -> 227970 -0.02%
  dse.NumCFGChecks 641199 -> 641095 -0.02%
  dse.NumCFGSuccess 8308 -> 8307 -0.01%
  gvn.NumGVNEqProp 426613 -> 426574 -0.01%
  dse.NumFastStores 1093523 -> 1093439 -0.01%
  correlated-value-propagation.NumPhis 1238993 -> 1238911 -0.01%
  dse.NumGetDomMemoryDefPassed 1298938 -> 1298873 -0.01%
  gvn.NumPRELoad 948437 -> 948392 -0.00%

+12 lightgbm/c_api.ll
+11 lightgbm/application.ll
+4 quantlib/fdmbatesop.ll
+3 glslang/ShaderLang.ll
+1 openmpi/crc.ll
+0 proxygen/RFC1867.ll
+0 velox/Base64.ll
-1 abc/decompress.ll
-1 c3c/sema_initializers.ll
-1 ffmpeg/mxfenc.ll
-1 harfbuzz/gsubgpos-context.ll
-1 harfbuzz/hb-subset-serialize.ll
-1 image-rs/1clnprdgqfw2q9lq.ll
-2 cvc5/SimpSolver.ll
-2 ffmpeg/mpegts.ll
-2 xgboost/updater_refresh.ll
-3 clamav/aspack.ll
-4 arrow/device.ll
-4 box2d/imgui_tables.ll
-4 darktable/accelerators.ll
-4 darktable/crx.ll
-4 folly/AsyncSocket.ll
-4 folly/Zlib.ll
-4 glslang/Pp.ll
-4 glslang/PpScanner.ll
-4 libzmq/socket_base.ll
-4 linux/hsu.ll
-4 linux/serial_core.ll
-4 lvgl/lv_buttonmatrix.ll
-4 minetest/CGUIScrollBar.ll
-4 openjdk/compileBroker.ll
-4 openjdk/jvmciCompilerToVM.ll
-4 openjdk/pngrutil.ll
-4 wireshark/packet-smb.ll
-4 z3/nlsat_simple_checker.ll
-5 hdf5/h5dump_ddl.ll
-5 ockam-rs/2v5jo34gglxi7dx1.ll
-6 typst-rs/3dimj4rf5dyrieyi.ll
-7 freetype/ftbase.ll
-7 wireshark/file_wrappers.ll
-8 abc/darRefact.ll
-8 bullet3/btSimulationIslandManagerMt.ll
-8 folly/Compression.ll
-8 folly/Load.ll
-8 proxygen/HPACKDecodeBuffer.ll
-8 proxygen/HTTP1xCodec.ll
-8 z3/datalog_parser.ll
-8 z3/sat_aig_finder.ll
-10 pola-rs/4i1zi5w77kchanzzu8mmseop2.ll
-12 folly/AsyncSSLSocket.ll
-12 proxygen/HQFramer.ll
-13 libquic/values.ll
-16 cmake/archive_write_set_format_mtree.ll
-16 minetest/CAnimatedMeshSceneNode.ll
-16 proxygen/HTTP2Codec.ll
-17 ruff-rs/evms2p4umzg02qbcch4ghcur3.ll
-20 proxygen/HTTP2Framer.ll
-28 jsonnet/rapidyaml.ll
-32 minetest/COpenGLDriver.ll

@github-actions

Copy link
Copy Markdown
Contributor

Here's a concise summary of the major changes in this LLVM IR diff:

  1. Phi Node Predecessor Updates: Multiple phi instructions had their predecessor block lists updated (e.g., %indvars.iv, %19, %143, %160, %239) to reflect control-flow changes—most commonly replacing references to now-removed or renamed blocks (like .thread, .thread206, ft_mem_realloc.exit.thread20, etc.) with correct successors (e.g., %246, %120, %157). This indicates restructuring of loop headers, exit paths, or error-handling branches.

  2. Dead Code Removal: Several unconditional stores and basic blocks were eliminated—including redundant .thread blocks (e.g., .thread, .thread206, .thread100) that performed identical stores followed by unconditional branches. These were replaced with direct control flow or merged into existing paths, reducing code size and simplifying CFGs.

  3. TBAA Metadata Reordering: In harfbuzz and hdf5, TBAA type descriptors (!142, !143, !144, !258, !259, !260) were reordered to match updated field layouts—specifically swapping offsets for pointer vs. integer fields within structs like hb_vector_t. This ensures memory access annotations remain semantically accurate after structural changes.

  4. Cleanup of Redundant Stores and Branches: Stores to zero or null (e.g., store i32 0, ptr %2, ..., store ptr null, ptr %x, ...) were removed where they preceded overwrites or were unreachable. Likewise, branches to dead blocks (e.g., br label %_ZN...exit.thread) were replaced with direct jumps to live successors, improving optimization potential.

  5. Exception Handling & Landing Pad Refinements: In libquic, lightgbm, and ockam-rs, landing pad logic was simplified—replacing explicit resume/cleanup blocks with direct resume from invoke sites, and updating phi nodes in cleanup blocks to reference correct predecessors. This streamlines exception propagation and reduces IR complexity.

All changes are consistent with post-optimization cleanups (e.g., after loop rotation, dead code elimination, or TBAA-aware struct layout changes) and preserve semantics while improving IR quality for downstream passes.

model: qwen-plus-latest
CompletionUsage(completion_tokens=524, prompt_tokens=107734, total_tokens=108258, completion_tokens_details=None, prompt_tokens_details=None)

Comment on lines +1703 to +1704
store i64 0, ptr %84, align 8, !tbaa !83, !alias.scope !216
store ptr %81, ptr %12, align 8, !tbaa !87, !noalias !216

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression.

@antoniofrighetto

Copy link
Copy Markdown

/close

@github-actions github-actions Bot closed this Feb 17, 2026
@dtcxzyw
dtcxzyw deleted the test-run22074258187 branch February 21, 2026 06:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants