pre-commit: PR169923

[zyw-bot]

Link: llvm/llvm-project#169923
Requested by: @nikic

[zyw-bot]

Diff mode

runner: ariselab-64c-docker
baseline: llvm/llvm-project@6dbdfd8
patch: llvm/llvm-project#169923
sha256: 297293fff3e531c715f6c00c3a39284c49371981ca22e636182ae90ee2af2083
commit: 9e4fe56

6336 files changed, 18952251 insertions(+), 19096274 deletions(-)

Improvements:
  assume-builder.NumAssumeBuilt 47 -> 427955 +910442.55%
  assume-builder.NumBundlesInAssumes 47 -> 427955 +910442.55%
  licm.NumMovedCalls 36929 -> 38907 +5.36%
  sroa.NumStoresPredicated 3634 -> 3820 +5.12%
  function-attrs.NumCapturesNone 3402796 -> 3539068 +4.00%
  instcombine.NumDeadInst 41043313 -> 41792443 +1.83%
  memdep.NumCacheDirtyNonLocalPtr 23038 -> 23176 +0.60%
  instcombine.NumCombined 119919379 -> 120327352 +0.34%
  simplifycfg.NumHoistCommonCode 878984 -> 881379 +0.27%
  local.NumPHICSEs 184162 -> 184609 +0.24%
Regressions:
  function-attrs.NumCapturesPartial 501218 -> 364921 -27.19%
  constraint-elimination.NumCondsRemoved 3350110 -> 2622047 -21.73%
  correlated-value-propagation.NumCmps 271568 -> 243521 -10.33%
  early-cse.NumSimplify 28237495 -> 27902184 -1.19%
  instcount.NumICmpInst 23792266 -> 23559426 -0.98%
  sroa.NumLoadsPredicated 14459 -> 14327 -0.91%
  simplifycfg.NumHoistCommonInstrs 2496374 -> 2486758 -0.39%
  licm.NumHoisted 5269943 -> 5251458 -0.35%
  simplifycfg.NumSinkCommonInstrs 826959 -> 824326 -0.32%
  loop-instsimplify.NumSimplified 182352 -> 181958 -0.22%

+18 deku-rs/5vpv8kgcwbq2ocxo8cxpek7im.ll
+16 stat-rs/rkxxfn3f5mhspne.ll
+14 tikv-rs/4sohgqjmmmwbwrelv7h1i20q9.ll
+11 influxdb-rs/2rfehyqstyicagph.ll
+10 actix-rs/190uhijawk1lki5o.ll
+10 quinn-rs/4qf6j99489y125gs242873d2k.ll
+8 meilisearch-rs/2fpcolt33ttb4v7z.ll
+8 ruby/vm_trace.ll
+8 softposit-rs/1jooigl29qhneyer.ll
+8 turborepo-rs/1cvlwe6zm1qaq81s6s5zko6gi.ll
+7 velox/SsdFile.ll
+6 egg-rs/1m5ocab1mrcx5l24.ll
+6 egg-rs/55a7hv010cxk6f68.ll
+6 quantlib/gaussian1dnonstandardswaptionengine.ll
+6 smol-rs/3jwiggzh2qey4o2f.ll
+6 softposit-rs/4wrr62dd33canpwl.ll
+6 softposit-rs/kf9u47qfx5x7qom.ll
+6 stat-rs/3koi1gt1wwkf7v6z.ll
+6 yara-x-rs/8a9gse2aldv1htkmin7yrr01c.ll
+6 yara-x-rs/a34pw7z58x6o14kcmfroib8up.ll
+5 abseil-cpp/reflection_test.ll
+5 actix-rs/305jwhumkt6l000n.ll
+5 ipopt/SensDenseGenSchurDriver.ll
+5 jiff-rs/d5ptug8pk58j4ioidoz8wi1r8.ll
+5 pingora-rs/e93q9y45cqp7emaz0boy5m6s2.ll
+5 ring-rs/52ihu0vizw1hcp4s.ll
+4 abseil-cpp/cord_rep_crc.ll
+4 abseil-cpp/reflection.ll
+4 diesel-rs/1h5ssk6l01034x01.ll
+4 tikv-rs/3zlxqcm5fmm23kyz1ebfkwze6.ll
+3 ockam-rs/1z7cyf6rmx8jvemg.ll
+3 quantlib/gaussian1dmodel.ll
+3 quiche-rs/918pywf5kjejgzslmxsek0i51.ll
+3 quinn-rs/eayza7vkb46gzjwgeak3s8z5x.ll
+3 yara-x-rs/1x4vc187urox7v1altiglt5df.ll
+2 actix-rs/5a33a9xfp20c1mrr.ll
+2 csmith/Variable.ll
+2 raft-rs/47x49b2y4duzhm1v2f6oqasii.ll
+1 abseil-cpp/cord_test.ll
+1 darktable/DcsDecoder.ll
+1 mini-lsm-rs/pew1bqmcl3zb6gg.ll
+1 pingora-rs/4rsii32vb3uxsu1nwv70pm7gl.ll
+1 proxygen/HeaderTable.ll
+1 regex-rs/33whcn8n29l9c6ys.ll
+1 stat-rs/2ao4u4y4ndqxwz8u.ll
+1 wasmedge/function.ll
+1 wasmi-rs/cj4u4ke91rmwgbf3jeowkct8u.ll
-1 abc/abcDfs.ll
-1 assimp/glTF2Importer.ll
-1 cmake/nghttp2_session.ll
-1 cpython/_functoolsmodule.ll
-1 cpython/_interpchannelsmodule.ll
-1 egg-rs/3kvzvcniz931d1o8.ll
-1 faiss/IVFlib.ll
-1 icu/fpositer.ll
-1 icu/rematch.ll
-1 jemalloc/tcache.ll
-1 jiff-rs/bc87zufzpghb0zqt1svthjsy4.ll
-1 libigl/point_areas.ll
-1 libquic/x509name.ll
-1 libzmq/socket_base.ll
-1 mini-lsm-rs/2r9gly04tqoqnem4.ll
-1 mitsuba3/builder.ll
-1 mitsuba3/rapass.ll
-1 openssl/ml_kem_codecs.ll
-1 openssl/quic_impl.ll
-1 openssl/quic_tls_api.ll
-1 quinn-rs/0x4duqd2ka75dnynyn9eu6svo.ll
-1 quinn-rs/94z0rmq3mlh67s9f6xgkqgoqb.ll
-1 ring-rs/1y6av6yno9dk5en7.ll
-1 ripgrep-rs/5bsdb1a7c3bw15pg.ll
-1 rocksdb/arena_wrapped_db_iter.ll
-1 serde-rs-json/36shr7j8gl5gy6fn.ll
-1 serde-rs-json/3o41byb1p1zh3720.ll
-1 smol-rs/21eidrukyvr99qqv.ll
-1 syn/4pem7cta6fyqelao.ll
-1 tikv-rs/96y9hk39bcjsdy0glqmdl20ki.ll
-1 typst-rs/1ln40ib1b6suqgfg.ll
-2 abseil-cpp/cord_rep_consume.ll
-2 actix-rs/83dw2wnqoscdmtc.ll
-2 anki-rs/yhvjx27msub7381.ll
-2 c3c/sema_expr.ll
-2 clap-rs/1rbie63mhpvpjak.ll
-2 csmith/FactUnion.ll
-2 delta-rs/2x36mf26z3hhv78u.ll
-2 html5ever-rs/25w8hapxpxs3e2f0.ll
-2 hyper-rs/4lwa0ukf5hd0n1ju.ll
-2 icu/fmtable.ll
-2 influxdb-rs/2hwft84a2d6liqrp.ll
-2 memcached/extstore.ll
-2 minetest/l_nodemeta.ll
-2 mini-lsm-rs/56vhdkxtzvzc0a1c.ll
-2 ring-rs/2y22w349mvmovez2.ll
-2 ropey-rs/2p9nf7n6i9ycxebu.ll
-2 serde-rs-json/fa1ay6huy2tg8jn.ll
-2 sundials/arkode_splittingstep_coefficients.ll
-2 syn/19z3k5eqgbxjiezn.ll
-2 tokio-rs/4mr1mvhll2ekuv31.ll
-2 typst-rs/1ieizyrayutd063g.ll
-2 typst-rs/1jbfz0m1n0wz4a3e.ll
-2 velox/SignatureBinder.ll
-2 wasmi-rs/4m6wfct6oj4zo483nw31mpwkd.ll
-2 wasmi-rs/enc4l3d98u1r0eousbwvhx9r5.ll
-3 anki-rs/2lb7ct7ebbwm4pw.ll
-3 anki-rs/4dwzlylnzyd0t16.ll
-3 folly/SocketAddress.ll
-3 mini-lsm-rs/300n4o8itowzm2cs.ll
-3 regex-rs/4p7mqoqm6h8kkgbs.ll
-3 sqlite/sqlite3.ll
-4 opencv/node.ll
-4 opencv/ransac_solvers.ll
-4 pola-rs/0vv5nrmroubc6gns0tdninfa0.ll
-4 tokio-rs/qqq7nw5h0oohsoh.ll
-5 proxygen/Huffman.ll
-5 serde-rs-json/2bynnyw1do6foacb.ll
-6 rand-rs/1l07c6ml3r7a5z09.ll
-7 boost/target.ll
-7 graphviz/mainwindow.ll
-8 elfshaker-rs/9dox7o1ijtul0pputqol6b06j.ll
-8 qdrant-rs/4cyb8cwzfo9kxjxt.ll
-9 ocio/CTFTransform.ll
-9 re2/regexp.ll

[github-actions]

This patch modernizes LLVM IR by replacing explicit null-check icmp ne ptr %p, null + llvm.assume(i1 %cond) sequences with the more expressive and semantically richer llvm.assume(i1 true) [ "nonnull"(ptr %p) ] intrinsic.

The major changes are:

1. NonNull Assumption Migration: Over 100 instances across numerous benchmarks (e.g., abseil-cpp, actix-rs, anki-rs, boost, clap-rs, faiss, graphviz, hyper-rs, icu, influxdb-rs, libquic, memcached, mini-lsm-rs, mitsuba3, ocio) are updated to use the "nonnull" attribute on llvm.assume. This provides stronger, more actionable information to the optimizer than a generic boolean assumption.

2. Removal of Redundant TBAA/NonNull/Noundef Metadata: In many places (e.g., cord_rep_crc.ll, reflection.ll, Variable.ll, cord_test.ll, reflection_test.ll, DcsDecoder.ll, cord_rep_consume.ll), the !nonnull and !noundef metadata tags are removed from load instructions. This is because the new "nonnull" assumption on llvm.assume already conveys the same non-null guarantee, making the redundant load metadata unnecessary.

3. LLVM Function Attribute Updates: The declaration for @llvm.assume is updated in multiple files (cord_rep_crc.ll, deku-rs/...ll, egg-rs/...ll, ipopt/...ll, jemalloc/...ll) to use the precise attribute set mustprogress nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: write), replacing older, less specific sets like memory(argmem: readwrite).

4. Phi Node and Branch Target Adjustments: Several patches fix phi node operands and branch targets that were misaligned due to previous rewrites (e.g., anki-rs/...ll, elfshaker-rs/...ll, mitsuba3/...ll, rapass.ll). This ensures control flow integrity after other transformations.

5. Cleanup of Obsolete Profiling and Debug Metadata: The patch removes obsolete or unused metadata, such as !19 = !{} and !20 = !{!"branch_weights", ..."} in cord_rep_crc.ll, and updates !prof metadata to point to the correct, newly defined !19 in several files, improving metadata hygiene.

model: qwen-plus-latest
CompletionUsage(completion_tokens=570, prompt_tokens=105185, total_tokens=105755, completion_tokens_details=None, prompt_tokens_details=None)

[nikic]

/close