FIX for file permissions - using too high causes that gem install set 777 on files installed in system #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that's insecure on production env.
infakt-HNP
changed the title
Closed
infakt-HNP
changed the title
|
Could you please comment more on the change which was made as well as the outcome. |
|
@dspinhirne all files in your repo have chmod 755, is causes that bundle install set chmod 777 during deployments. That's a security issue, for example nginx user or apache can replace gem files on the server. |
|
@dspinhirne I see that a version is 2.0.4, but in ruby gems that's 2.0.3 https://rubygems.org/gems/netaddr/versions/ |
siyuee
pushed a commit
to siyuee/netaddr-rb
that referenced
this pull request
Feb 13, 2020
As per dspinhirne#20, this change chmods all files in the directory to have 644 permissions instead of 755.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that's insecure on production envs.