Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(404-page): add basic 404 page for #6 #471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kjbrum
Copy link

@kjbrum kjbrum commented Oct 25, 2019

No description provided.

@kjbrum kjbrum mentioned this pull request Oct 25, 2019
@kjbrum
Copy link
Author

kjbrum commented Oct 25, 2019

This will resolve #6.

<h1>404</h1>
<p>
Oops, look like there&rsquo;s nothing to see here!
<br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than a break tag, i think i'd go with separate paragraphs here

<br />
This page has either been removed or never existed.
</p>
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think there should be a need for the link to be wrapped in a paragraph. if simply for spacing, emotion should be available to apply css rules. happy to walk through those details if they would be helpful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emotion isn't in site yet. It would need to be normal react styling at this point I think.

Copy link
Member

@travi travi Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i realized the same after posting this. simple styling would probably be fine for this PR. once we merge here, i think we'd probably follow up to extract to components fairly shortly afterward, so that would open up more options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants