fix: Few UI improvements (#222)

* UI fix in Change password

* Improved login UI

Author: somenath1435

app/src/main/java/com/example/saar/ChangeCredentials/ChangePasswordFragment.java

@@ -69,7 +69,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
         if(getActivity().getIntent().hasExtra("rollno")){
             forgot_password=true;
             old_password.setText("Dummy");
-            old_password.setVisibility(View.GONE);
+            view.findViewById(R.id.oldPasswordInputLayout).setVisibility(View.GONE);
             rollno=getActivity().getIntent().getStringExtra("rollno");
         }
 

app/src/main/java/com/example/saar/ChangeCredentials/ForgotPasswordFragment.java

@@ -46,9 +46,9 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
                              Bundle savedInstanceState) {
         // Inflate the layout for this fragment
         View rootView = inflater.inflate(R.layout.fragment_forgot_password, container, false);
-        email=rootView.findViewById(R.id.email_text_forgot_password);
-        rollno=rootView.findViewById(R.id.roll_text_forgot_password);
-        forgotPassword=rootView.findViewById(R.id.forgot_password_button);
+        email = rootView.findViewById(R.id.email_text_forgot_password);
+        rollno = rootView.findViewById(R.id.roll_text_forgot_password);
+        forgotPassword = rootView.findViewById(R.id.forgot_password_button);
         return rootView;
     }
 
@@ -60,7 +60,14 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
         forgotPassword.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View v) {
-                requestDatas();
+                String email_text = email.getText().toString();
+                String rollno_text = rollno.getText().toString();
+                if (email_text.isEmpty() || rollno_text.isEmpty())
+                    Toast.makeText(getContext(), getResources().getString(R.string.enter_all_fields), Toast.LENGTH_LONG).show();
+                else if (Utils.isNetworkConnected(getContext()))
+                    requestDatas();
+                else
+                    Toast.makeText(getContext(), getString(R.string.no_internet), Toast.LENGTH_LONG).show();
             }
         });
     }
@@ -85,8 +92,8 @@ public void onResponse(String response) {
                         Toast.makeText(getContext(), getString(R.string.success_forgot_password_request), Toast.LENGTH_LONG).show();
 
                         Intent intent = new Intent(getContext(), OtpActivity.class);
-                        intent.putExtra("rollno",rollno.getText().toString());
-                        intent.putExtra("forgot_password","forgot_password");
+                        intent.putExtra("rollno", rollno.getText().toString());
+                        intent.putExtra("forgot_password", "forgot_password");
                         startActivity(intent);
                     } else {
                         Timber.d(getString(R.string.error_Forgot_password));

app/src/main/res/layout/fragment_login.xml

@@ -30,7 +30,7 @@
                 android:layout_marginStart="@dimen/margin_big"
                 android:layout_marginTop="@dimen/login_card_margin"
                 android:layout_marginEnd="@dimen/margin_big"
-                android:layout_marginBottom="@dimen/margin_50dp"
+                android:layout_marginBottom="@dimen/margin_30dp"
                 android:background="@color/white"
                 app:cardCornerRadius="@dimen/card_login_radius"
                 app:cardElevation="@dimen/card_login_elevation">
@@ -116,7 +116,8 @@
                 android:padding="@dimen/padding_medium"
                 android:text="@string/verify_email"
                 android:textColor="@color/colorPrimary"
-                android:textSize="@dimen/textsize_medium" />
+                android:textSize="@dimen/textsize_medium"
+                android:layout_marginBottom="@dimen/margin_medium"/>
 
             <android.support.v7.widget.AppCompatTextView
                 android:id="@+id/skip_login"
@@ -135,7 +136,7 @@
                 android:layout_height="wrap_content"
                 android:layout_below="@id/skip_login"
                 android:layout_centerHorizontal="true"
-                android:layout_marginTop="@dimen/margin_big"
+                android:layout_marginTop="@dimen/margin_medium"
                 android:layout_marginBottom="@dimen/margin_big"
                 android:padding="@dimen/padding_medium"
                 android:text="@string/forgot_password"