Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Bug with updateForm method when updating input data only #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AngryBeaver
Copy link

arrays in data that changed in size needs to increase or decrease formGroup

PR Type

What changes does this PR include (check all that apply)?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build process changes
[ ] Documentation changes
[ ] Other... please describe:

Related issue / current behavior

if we updateForm with changes in input only the initializeForm is not triggered.

possible fixes this:
#256
maybe this:
#195

New behavior

keep it stupid simple it always rerender Form even if the change is only in data

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Any other relevant information

The Change will possibly slow down as each data change will now trigger a Form rerender but its clean simple stupid and not performance optimized as i currently do not see any problems.
CleanCode:
http://clean-code-developer.com/grades/grade-1-red/#Keep_it_simple_stupid_KISS
http://clean-code-developer.com/grades/grade-1-red/#Beware_of_Optimizations

arrays in data that changed in size needs to increase or decrease formGroup
keep it simple stupid it will now always rerender Form with initializeForm.
@catull
Copy link

catull commented Jun 5, 2018

@AngryBeaver How about you create a PR against https://github.com/shamoons/ng-json-schema-form. Shamoon is the next maintainer of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants