fix Bug with updateForm method when updating input data only #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrays in data that changed in size needs to increase or decrease formGroup
PR Type
What changes does this PR include (check all that apply)?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build process changes
[ ] Documentation changes
[ ] Other... please describe:
Related issue / current behavior
if we updateForm with changes in input only the initializeForm is not triggered.
possible fixes this:
#256
maybe this:
#195
New behavior
keep it stupid simple it always rerender Form even if the change is only in data
Does this PR introduce a breaking change?
[ ] Yes
[x] No
Any other relevant information
The Change will possibly slow down as each data change will now trigger a Form rerender but its clean simple stupid and not performance optimized as i currently do not see any problems.
CleanCode:
http://clean-code-developer.com/grades/grade-1-red/#Keep_it_simple_stupid_KISS
http://clean-code-developer.com/grades/grade-1-red/#Beware_of_Optimizations