Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shell completion #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add shell completion #197

wants to merge 1 commit into from

Conversation

mohd-akram
Copy link
Contributor

@mohd-akram mohd-akram commented Mar 20, 2019 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Mar 20, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 81.123% when pulling b4a48e2 on mohd-akram:shell-completion into ecfeee9 on dschep:master.

@mohd-akram mohd-akram force-pushed the shell-completion branch 4 times, most recently from 93b4f0e to e531d41 Compare March 20, 2019 02:43
dschep
dschep reviewed Mar 20, 2019
View reviewed changes
Copy link
Owner

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Didn't realize this was so easy to implement! just a question about dependencies

ntfy/cli.py Show resolved Hide resolved
@mohd-akram
Copy link
Contributor Author

Is this good to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschep dschep dschep left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohd-akram @coveralls @dschep