Open
Conversation
41 tasks
cho-m
commented
Aug 12, 2025
CMakeLists.txt
Outdated
| date_time | ||
| system | ||
| program_options | ||
| OPTIONAL_COMPONENTS |
Author
There was a problem hiding this comment.
Made PR a draft as need to figure out CMake < 3.11 where OPTIONAL_COMPONENTS doesn't exist.
Laserlicht
reviewed
Aug 15, 2025
Comment on lines
+182
to
+186
| find_package(Boost REQUIRED COMPONENTS ${BOOST_REQUIRED_COMPONENTS}) | ||
| if(Boost_MAJOR_VERSION EQUAL 1 AND Boost_MINOR_VERSION LESS 69) | ||
| list(APPEND BOOST_REQUIRED_COMPONENTS system) | ||
| find_package(Boost REQUIRED COMPONENTS ${BOOST_REQUIRED_COMPONENTS}) | ||
| endif() |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Author
There was a problem hiding this comment.
Boost_MAJOR_VERSION/Boost_MINOR_VERSION is set by the first find_package so change won't work.
Laserlicht
reviewed
Aug 15, 2025
| program_options | ||
| ) | ||
| find_package(Boost REQUIRED COMPONENTS ${BOOST_REQUIRED_COMPONENTS}) | ||
| if(Boost_MAJOR_VERSION EQUAL 1 AND Boost_MINOR_VERSION LESS 69) |
There was a problem hiding this comment.
Suggested change
| if(Boost_MAJOR_VERSION EQUAL 1 AND Boost_MINOR_VERSION LESS 69) | |
| if(Boost_MAJOR_VERSION EQUAL 1 AND Boost_MINOR_VERSION LESS 89) |
There was a problem hiding this comment.
system module/library is a stub since 1.69 according to the PR description, so this is correct
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the upcoming Boost 1.89.0 release, the Boost.System stub library introduced back in 1.691 has been removed (boostorg/system@7a495bb), which causes a CMake error.
This PR change using
OPTIONAL_COMPONENTSis based on upstream recommendationhttps://github.com/boostorg/system/issues/132#issuecomment-3146378680given Boost 1.37 is still allowed.Footnotes
https://www.boost.org/doc/libs/1_69_0/libs/system/doc/html/system.html#changes_in_boost_1_69 ↩