Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirewallProfile: Fix issue #428 dsc firewallprofile #519

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brajjan
Copy link

@brajjan brajjan commented Sep 9, 2022

Pull Request (PR) description

Added PolicyStore parameter to Get/Set/Test-TargetResource for DSC_FirewallProfile - fixes Issue #428 .

Not updated Pester tests as my knowledge of Pester tests are close to 0

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97%. Comparing base (9d6e70d) to head (0863403).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #519   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        28     28           
  Lines      2078   2079    +1     
===================================
+ Hits       2028   2029    +1     
  Misses       50     50           
Files Coverage Δ
...urces/DSC_FirewallProfile/DSC_FirewallProfile.psm1 100% <100%> (ø)

@PlagueHO PlagueHO self-requested a review September 16, 2022 06:47
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Sep 16, 2022
@johlju
Copy link
Member

johlju commented Oct 1, 2022

@brajjan when you are ready, take this PR out of draft so it can be reviewed.

@brajjan brajjan marked this pull request as ready for review October 2, 2022 10:07
@eppNator
Copy link

eppNator commented Aug 6, 2024

I'm not a developer but I just wanted to reiterate that this would be a very useful change to get implemented. Any chance that this could still happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewall and FirewallProfile: Add PolicyStore to allow targeting local group policy
4 participants