Localize Microsoft/Mojang authentication error messages #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscalzi
reviewed
Feb 22, 2024
dscalzi
approved these changes
Feb 22, 2024
san-antonio0978
pushed a commit
to Stargate-Atohara/StargateAtoharaLauncher
that referenced
this pull request
Feb 29, 2024
* Move Microsoft/Mojang error message to lang file. * Add mstfLogin to language file
busybox11
pushed a commit
to dremixam/BigzbeulLauncher
that referenced
this pull request
Sep 15, 2024
* Move Microsoft/Mojang error message to lang file. * Add mstfLogin to language file
busybox11
pushed a commit
to dremixam/BigzbeulLauncher
that referenced
this pull request
Sep 15, 2024
* Move Microsoft/Mojang error message to lang file. * Add mstfLogin to language file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, remove the function that generates error messages from helios-core by dscalzi/helios-core#6.
In this PR, add a function to generate error messages on the HeliosLauncher side and localize it using LangLoader.
And by the way, I added [js.settings.msftLogin] in the language file because it was causing errors due to missing it.