Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include release name and body in the output #23

Merged
merged 5 commits into from
May 6, 2021

Conversation

maciejp
Copy link
Contributor

@maciejp maciejp commented May 5, 2021

as those parameters are useful when deploying applications.

This PR includes a few other minor improvements, namely:

  • adding a workflow for verifying that the action works as expected
  • fixing the Readme by tagging token as required
  • improve the descriptions of parameters in the Readme

maciejp added 5 commits May 5, 2021 09:41
as those parameters are often useful when deploying a release.
It runs on pull requests and uses the code from the branch to run the action. The output has to be checked manually.
as a token is necessary for making calls to GitHub API
and using the same parameter descriptions in `action.yaml`
@maciejp maciejp marked this pull request as draft May 5, 2021 08:54
@maciejp maciejp force-pushed the add-release-name-and-body branch from 5396350 to 4ffe891 Compare May 5, 2021 09:04
@maciejp maciejp marked this pull request as ready for review May 5, 2021 09:04
@maciejp
Copy link
Contributor Author

maciejp commented May 5, 2021

@dsaltares I don't know how (or if it's possible at all) to make this workflow run in this PR. You can check the result on the PR I opened for my fork

Copy link
Owner

@dsaltares dsaltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, we have some kind of CI!

@dsaltares dsaltares merged commit 1421d10 into dsaltares:master May 6, 2021
@maciejp
Copy link
Contributor Author

maciejp commented May 6, 2021

My pleasure! Any chance you could create a new release? I'm eager to remove a bunch of ugly CURLs from my actions :)

@maciejp
Copy link
Contributor Author

maciejp commented May 16, 2021

@dsaltares ? :)

@maciejp
Copy link
Contributor Author

maciejp commented Jun 18, 2021

Hi @dsaltares , would you find some time to create a new release? 🙂
I already have a PR open in one of my company's projects that depends on this change.

BSteffaniak pushed a commit to FlatLang/fetch-airship that referenced this pull request Oct 12, 2022
include release name and body in the output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants