Skip to content

Conversation

@amontoison
Copy link
Collaborator

solver.x and solver.y are the solutions for all solvers now.

@mtanneau
Copy link
Member

mtanneau commented Sep 8, 2021

I can't merge until Krylov.jl v0.7.7 has been tagged

@amontoison
Copy link
Collaborator Author

It should work now : JuliaRegistries/General#44479

@amontoison amontoison closed this Sep 8, 2021
@amontoison amontoison reopened this Sep 8, 2021
@mtanneau
Copy link
Member

@amontoison can you update the compat entry in test/Project.toml as well?

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #104 (5fc1484) into master (0248d36) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   90.60%   90.55%   -0.06%     
==========================================
  Files          43       43              
  Lines        2587     2688     +101     
==========================================
+ Hits         2344     2434      +90     
- Misses        243      254      +11     
Impacted Files Coverage Δ
src/KKT/Krylov/sqd.jl 94.59% <100.00%> (ø)
src/LinearAlgebra/LinearAlgebra.jl 14.28% <0.00%> (-2.39%) ⬇️
src/Interfaces/MOI/MOI_wrapper.jl 79.66% <0.00%> (-1.38%) ⬇️
src/IPM/MPC/step.jl 95.39% <0.00%> (-1.25%) ⬇️
src/problemData.jl 91.81% <0.00%> (-0.74%) ⬇️
src/IPM/HSD/HSD.jl 87.50% <0.00%> (-0.69%) ⬇️
src/IPM/MPC/MPC.jl 89.47% <0.00%> (-0.60%) ⬇️
src/IPM/HSD/step.jl 95.45% <0.00%> (-0.52%) ⬇️
src/KKT/Cholmod/sqd.jl 100.00% <0.00%> (ø)
src/Presolve/fixed_variable.jl 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0248d36...5fc1484. Read the comment docs.

@mtanneau mtanneau merged commit b0b3496 into ds4dm:master Sep 18, 2021
@amontoison amontoison deleted the hotfix_krylov branch September 27, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants