error: Error: spawnSync git ENOBUFS #166

brunolemos · 2019-08-30T20:06:13Z

Small reproduction:

Create an empty folder with only one file: package.json

{
  "name": "rw",
  "dependencies": {
    "react-window": "1.8.5"
  }
}

Make some changes inside node_modules/react-window/dist files
npx patch-package react-window
If fails with error below:

[17:05:40] brunolemos:rw $ patch-package react-window
patch-package 6.1.2
• Creating temporary folder
• Installing [email protected] with yarn
• Diffing your files with clean files

{
  error: Error: spawnSync git ENOBUFS
      at Object.spawnSync (internal/child_process.js:1041:20)
      at Object.spawnSync (child_process.js:607:24)
      at Function.spawnSync [as sync] (/usr/local/lib/node_modules/patch-package/node_modules/cross-spawn/index.js:26:23)
      at Object.exports.spawnSafeSync (/usr/local/lib/node_modules/patch-package/dist/spawnSafe.js:10:32)
      at git (/usr/local/lib/node_modules/patch-package/dist/makePatch.js:73:32)
      at Object.makePatch (/usr/local/lib/node_modules/patch-package/dist/makePatch.js:104:26)
      at /usr/local/lib/node_modules/patch-package/dist/index.js:48:25
      at Array.forEach (<anonymous>)
      at Object.<anonymous> (/usr/local/lib/node_modules/patch-package/dist/index.js:47:22)
      at Module._compile (internal/modules/cjs/loader.js:868:30) {
    errno: 'ENOBUFS',
    code: 'ENOBUFS',
    syscall: 'spawnSync git',
    path: 'git',
    spawnargs: [
      'diff',
      '--cached',
      '--no-color',
      '--ignore-space-at-eol',
      '--no-ext-diff'
    ]
  },
  status: null,
  signal: 'SIGTERM',
  output: [
    null,
    <Buffer 64 69 66 66 20 2d 2d 67 69 74 20 61 2f 6e 6f 64 65 5f 6d 6f 64 75 6c 65 73 2f 72 65 61 63 74 2d 77 69 6e 64 6f 77 2f 64 69 73 74 2f 69 6e 64 65 78 2d ... 1056718 more bytes>,
    <Buffer >
  ],
  pid: 79859,
  stdout: <Buffer 64 69 66 66 20 2d 2d 67 69 74 20 61 2f 6e 6f 64 65 5f 6d 6f 64 75 6c 65 73 2f 72 65 61 63 74 2d 77 69 6e 64 6f 77 2f 64 69 73 74 2f 69 6e 64 65 78 2d ... 1056718 more bytes>,
  stderr: <Buffer >
}

/usr/local/lib/node_modules/patch-package/dist/makePatch.js:150
        throw e;
        ^
{
  error: Error: spawnSync git ENOBUFS
      at Object.spawnSync (internal/child_process.js:1041:20)
      at Object.spawnSync (child_process.js:607:24)
      at Function.spawnSync [as sync] (/usr/local/lib/node_modules/patch-package/node_modules/cross-spawn/index.js:26:23)
      at Object.exports.spawnSafeSync (/usr/local/lib/node_modules/patch-package/dist/spawnSafe.js:10:32)
      at git (/usr/local/lib/node_modules/patch-package/dist/makePatch.js:73:32)
      at Object.makePatch (/usr/local/lib/node_modules/patch-package/dist/makePatch.js:104:26)
      at /usr/local/lib/node_modules/patch-package/dist/index.js:48:25
      at Array.forEach (<anonymous>)
      at Object.<anonymous> (/usr/local/lib/node_modules/patch-package/dist/index.js:47:22)
      at Module._compile (internal/modules/cjs/loader.js:868:30) {
    errno: 'ENOBUFS',
    code: 'ENOBUFS',
    syscall: 'spawnSync git',
    path: 'git',
    spawnargs: [
      'diff',
      '--cached',
      '--no-color',
      '--ignore-space-at-eol',
      '--no-ext-diff'
    ]
  },
  status: null,
  signal: 'SIGTERM',
  output: [
    null,
    <Buffer 64 69 66 66 20 2d 2d 67 69 74 20 61 2f 6e 6f 64 65 5f 6d 6f 64 75 6c 65 73 2f 72 65 61 63 74 2d 77 69 6e 64 6f 77 2f 64 69 73 74 2f 69 6e 64 65 78 2d ... 1056718 more bytes>,
    <Buffer >
  ],
  pid: 79859,
  stdout: <Buffer 64 69 66 66 20 2d 2d 67 69 74 20 61 2f 6e 6f 64 65 5f 6d 6f 64 75 6c 65 73 2f 72 65 61 63 74 2d 77 69 6e 64 6f 77 2f 64 69 73 74 2f 69 6e 64 65 78 2d ... 1056718 more bytes>,
  stderr: <Buffer >
}
[17:05:44] brunolemos:rw $

The text was updated successfully, but these errors were encountered:

brunolemos · 2019-08-30T20:10:20Z

This only happens when I was trying to patch the .js.map files as well. Maybe they are too big.

pvinis · 2019-12-03T10:04:51Z

I don't think this should be closed. It would be cool to have a way to ignore these files.

ldco2016 · 2019-12-04T13:18:24Z

@brunolemos , why was this closed? I get the same error when I tried to patch [email protected]

I ran npx patch-package react-native-immediate-phone-call and I got:

* Creating temporary folder
* Installing [email protected] with npm
* Diffing your files with clean files

{
  error: Error: spawnSync git ENOBUFS

marcus-sa · 2019-12-13T09:49:54Z

Happens to me as well, and the file being added only contains a few bytes.

alepri51 · 2020-01-17T12:56:40Z

i've the same problem
any workaround?

SudoPlz · 2020-02-27T12:00:00Z

@alepri51 I temporarily worked around it and managed to create my patch by going to:

⁨node_modules⁩/patch-package⁩/dist⁩/makePatch.js line 108, specifically in this code:

return spawnSafe_1.spawnSafeSync("git", args, {
                cwd: tmpRepo.name,
                env: { HOME: tmpRepo.name },
            });

and added an extra option called maxBuffer to increase the buffer size to 100mb (it was 1 mb by default which is too low)

now the code looks like this:

return spawnSafe_1.spawnSafeSync("git", args, {
                cwd: tmpRepo.name,
                env: { HOME: tmpRepo.name },
                maxBuffer: 1024 * 1024 * 100
            });

and my patch was created successfully.
I hope that helps someone.

curio77 · 2020-03-08T17:43:35Z

Thank you, this helped. So we now need to patch-package patch-package? ;-)

SudoPlz · 2020-03-08T17:44:58Z

Hahaha yep

leejh3224 · 2020-04-08T09:26:13Z

This seems to be in a high priority

brussee · 2020-04-08T14:48:11Z

@alepri51 I temporarily worked around it and managed to create my patch by going to:

⁨node_modules⁩/patch-package⁩/dist⁩/makePatch.js line 108, specifically in this code:
return spawnSafe_1.spawnSafeSync("git", args, {
                cwd: tmpRepo.name,
                env: { HOME: tmpRepo.name },
            });
and added an extra option called maxBuffer to increase the buffer size to 100mb (it was 1 mb by default which is too low)

now the code looks like this:
return spawnSafe_1.spawnSafeSync("git", args, {
                cwd: tmpRepo.name,
                env: { HOME: tmpRepo.name },
                maxBuffer: 1024 * 1024 * 100
            });
and my patch was created successfully.
I hope that helps someone.

Here is a gist with the patch by @SudoPlz I'm using successfully:

https://gist.github.com/brussee/e382ed12ca007a88170289e54b526063

Timebutt · 2020-04-19T09:49:40Z

Can we get this fixed, possibly by upping the default maxBuffer or throwing a more clear error suggesting to up the maxBuffer when running the command?

I just ran into this too, and while it is incredibly meta to have to patch patch-package, it's not exactly the point ;)

bjacog · 2020-06-14T08:30:44Z

@Timebutt would it not be better to allow passing a maxBuffer param? There is a discussion of the same kind of problem in the Lerna repo here: lerna/lerna#479

It would also be nice to know what the buffer defaults to.

This issue comes up quite often when patching react-native packages for older repos as they could have some post-install steps which generate a large number of files.

NathanBWaters · 2020-10-01T17:26:09Z

Hit this when trying to patch the three node_module.
maxBuffer: 1024 * 1024 * 100 fixed it, thanks!

alpharder · 2020-11-26T15:37:06Z

So we basically need to patch the patch-package first in order to use it to patch other packages...

KrzysztofMadejski · 2021-01-12T10:07:46Z

Run into the same issue.

Artificially raising the maxBuffer seems to me a bit too much. I'd vote for cleaner message ("File too big: . Please raise --maxBuffer to over ") and option to change maxBuffer and optionally make it automatically adjust (check size of all files, if they are bigger than buffer than raise the bar before spawning git diff).

sbrighiu · 2021-02-16T18:25:50Z

To be honest if we raise maxBuffer to 2 mb it may fix everyone's issue ... just saying ..

ds300 · 2021-03-04T09:05:47Z

A fix for this was just released in v6.4.5. Thanks to @nomi9995 for making the PR 🙏🏼

sbrighiu · 2021-03-04T09:14:25Z

It seems too much for me, but it would fix the issue :)

In my case I was patching react native packages and when patching i had the build folder from android (build artifacts) included in the patch.. and that raised the current issue.

Simply removing that and being more mindful of the things actually added in the patch, would be my recommended way of handling situations like this.

Summary: Fixes [this issue](ds300/patch-package#166) Test Plan: 1. Make sure `patch-package react-native` works without needing to manually patch `patch-package` 2. Make sure `yarn cleaninstall` works and still patches correctly Reviewers: palys-swm Subscribers: KatPo, Adrian, atul Differential Revision: https://phabricator.ashoat.com/D1086

hirbod · 2021-12-20T02:02:08Z

Still failing for me with 6.4.7

numandev1 · 2021-12-21T12:23:19Z

@hirbod can you try to increase maxBuffer and try again?
https://github.com/nomi9995/patch-package/blob/fb10edb76ef54d23acab7fabf2e439a099ec23c9/src/makePatch.ts#L161

madeeha96 · 2022-01-09T10:57:41Z

My patch-package version is 6.4.7 and maxBuffer: 1024 * 1024 * 100 already added in the makePatch file. I still get this error

madeeha96 · 2022-01-09T11:00:33Z

Got it fixed by increasing maxBuffer to maxBuffer: 2048 * 1024 * 100

KrisLau · 2022-08-08T14:48:59Z

Happened for me with expo-modules-core with trying to apply the changes from this commit: expo/expo#18518

ArnabSwiggy · 2023-07-28T03:57:37Z

Got it fixed by increasing maxBuffer to maxBuffer: 2048 * 1024 * 100

That adds more issue, do check the diff file manually. If 1024 * 1024 * 100 is not working, means the diff is getting too large. Is it intentional? For me, it was no. Some random file diffs got added. Had to cleanup the diff manually.

YesSkyscrapers · 2023-07-31T07:07:11Z

Update lib helped me ;D
was "patch-package": "^6.5.1",
now "patch-package": "^8.0.0",

iArchin · 2023-11-06T09:18:31Z

I also have the same problem with the version 8.0.0

brunolemos closed this as completed Aug 30, 2019

brunolemos reopened this Dec 4, 2019

brussee mentioned this issue Apr 8, 2020

Patch react-native 0.59.9 failed #190

Open

Timebutt mentioned this issue Apr 19, 2020

Performance degradation with DOM mutation events slab/quill#1768

Closed

mruknowme mentioned this issue Nov 21, 2020

Cannot read property 'defaultView' of undefined error with angular 11.0.0-rc.0 akveo/nebular#2572

Closed

numandev1 mentioned this issue Feb 3, 2021

fix: Error: spawnSync git ENOBUFS #287

Merged

ds300 closed this as completed in #287 Mar 4, 2021

dependabot bot mentioned this issue Mar 8, 2021

Bump patch-package from 6.4.2 to 6.4.5 in /generators/app/templates jhipster/generator-jhipster-react-native#240

Closed

This was referenced Mar 15, 2021

build(deps-dev): bump patch-package from 6.2.2 to 6.4.7 niieani/codegen-typescript-graphql-module-declarations-plugin#10

Closed

Bump patch-package from 6.2.2 to 6.4.7 sgmelayu/web-stories-wp#171

Closed

imjamescrain mentioned this issue Oct 12, 2022

TypeError: expect.extend is not a function software-mansion/react-native-reanimated#3215

Closed

enzzoperez mentioned this issue Jan 25, 2023

🐛 Unmounting the Camera component does not turn off the torch mrousavy/react-native-vision-camera#1032

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

error: Error: spawnSync git ENOBUFS #166

error: Error: spawnSync git ENOBUFS #166

brunolemos commented Aug 30, 2019

brunolemos commented Aug 30, 2019

pvinis commented Dec 3, 2019

ldco2016 commented Dec 4, 2019

marcus-sa commented Dec 13, 2019 •

edited

Loading

alepri51 commented Jan 17, 2020

SudoPlz commented Feb 27, 2020 •

edited

Loading

curio77 commented Mar 8, 2020

SudoPlz commented Mar 8, 2020

leejh3224 commented Apr 8, 2020

brussee commented Apr 8, 2020 •

edited

Loading

Timebutt commented Apr 19, 2020

bjacog commented Jun 14, 2020

NathanBWaters commented Oct 1, 2020

alpharder commented Nov 26, 2020

KrzysztofMadejski commented Jan 12, 2021

sbrighiu commented Feb 16, 2021 •

edited

Loading

ds300 commented Mar 4, 2021

sbrighiu commented Mar 4, 2021 •

edited

Loading

hirbod commented Dec 20, 2021

numandev1 commented Dec 21, 2021 •

edited

Loading

madeeha96 commented Jan 9, 2022

madeeha96 commented Jan 9, 2022

KrisLau commented Aug 8, 2022 •

edited

Loading

ArnabSwiggy commented Jul 28, 2023

YesSkyscrapers commented Jul 31, 2023 •

edited

Loading

iArchin commented Nov 6, 2023

error: Error: spawnSync git ENOBUFS #166

error: Error: spawnSync git ENOBUFS #166

Comments

brunolemos commented Aug 30, 2019

Small reproduction:

brunolemos commented Aug 30, 2019

pvinis commented Dec 3, 2019

ldco2016 commented Dec 4, 2019

marcus-sa commented Dec 13, 2019 • edited Loading

alepri51 commented Jan 17, 2020

SudoPlz commented Feb 27, 2020 • edited Loading

curio77 commented Mar 8, 2020

SudoPlz commented Mar 8, 2020

leejh3224 commented Apr 8, 2020

brussee commented Apr 8, 2020 • edited Loading

Timebutt commented Apr 19, 2020

bjacog commented Jun 14, 2020

NathanBWaters commented Oct 1, 2020

alpharder commented Nov 26, 2020

KrzysztofMadejski commented Jan 12, 2021

sbrighiu commented Feb 16, 2021 • edited Loading

ds300 commented Mar 4, 2021

sbrighiu commented Mar 4, 2021 • edited Loading

hirbod commented Dec 20, 2021

numandev1 commented Dec 21, 2021 • edited Loading

madeeha96 commented Jan 9, 2022

madeeha96 commented Jan 9, 2022

KrisLau commented Aug 8, 2022 • edited Loading

ArnabSwiggy commented Jul 28, 2023

YesSkyscrapers commented Jul 31, 2023 • edited Loading

iArchin commented Nov 6, 2023

marcus-sa commented Dec 13, 2019 •

edited

Loading

SudoPlz commented Feb 27, 2020 •

edited

Loading

brussee commented Apr 8, 2020 •

edited

Loading

sbrighiu commented Feb 16, 2021 •

edited

Loading

sbrighiu commented Mar 4, 2021 •

edited

Loading

numandev1 commented Dec 21, 2021 •

edited

Loading

KrisLau commented Aug 8, 2022 •

edited

Loading

YesSkyscrapers commented Jul 31, 2023 •

edited

Loading