Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Commit

Permalink
Output the installed version of setuptools in the build log (heroku#1007
Browse files Browse the repository at this point in the history
)

Since:
* "explicit is better than implicit"
* we'll soon be upgrading setuptools, and debugging breakage caused by
  upgrades will be easier if versions are visible in the build log
  • Loading branch information
edmorley authored and dryan committed Nov 19, 2020
1 parent 7479bb8 commit ca2a6b3
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 13 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Master

- Output the installed version of pip in the build log (#1007).
- Output the installed version of pip and setuptools in the build log (#1007).
- Reduce the number of environment variables exposed to `bin/{pre,post}_compile` and other subprocesses (#1011)

# 173 (2020-07-21)
Expand Down
5 changes: 3 additions & 2 deletions bin/steps/python
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ if [ ! "$SKIP_INSTALL" ]; then
fi

PIP_VERSION='20.0.2'
SETUPTOOLS_VERSION='39.0.1'

if [[ "${PYTHON_VERSION}" == ${PY34}* ]]; then
# Python 3.4 support was dropped in pip 19.2+.
Expand All @@ -162,14 +163,14 @@ fi
# If a new Python has been installed or Pip isn't up to date:
if [ "$FRESH_PYTHON" ] || [[ ! $(pip --version) == *${PIP_VERSION}* ]]; then

puts-step "Installing pip ${PIP_VERSION}"
puts-step "Installing pip ${PIP_VERSION} and setuptools ${SETUPTOOLS_VERSION}"

# Remove old installations.
rm -fr /app/.heroku/python/lib/python*/site-packages/pip-*
rm -fr /app/.heroku/python/lib/python*/site-packages/setuptools-*

/app/.heroku/python/bin/python "$GETPIP_PY" pip=="${PIP_VERSION}" &> /dev/null
/app/.heroku/python/bin/pip install "$ROOT_DIR/vendor/setuptools-39.0.1-py2.py3-none-any.whl" &> /dev/null
/app/.heroku/python/bin/pip install "$ROOT_DIR/vendor/setuptools-${SETUPTOOLS_VERSION}-py2.py3-none-any.whl" &> /dev/null
fi

set -e
Expand Down
2 changes: 1 addition & 1 deletion test/run-features
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ testStandardRequirements() {

testPipenv() {
compile "pipenv"
assertCaptured "Installing pip 9.0.2"
assertCaptured "Installing pip 9.0.2 and setuptools 39.0.1"
assertCapturedSuccess
}

Expand Down
18 changes: 9 additions & 9 deletions test/run-versions
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ testPythonDefault() {
compile "pythonDefault"
assertCaptured $DEFAULT_PYTHON_VERSION
assertNotCaptured "security update"
assertCaptured "Installing pip 20.0.2"
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
assertCaptured "Installing SQLite3"
assertCapturedSuccess
}
Expand All @@ -25,7 +25,7 @@ testPython2() {
assertNotCaptured "python-2-7-eol-faq";
fi
assertNotCaptured "security update"
assertCaptured "Installing pip 20.0.2"
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
assertCaptured "Installing SQLite3"
assertCapturedSuccess
}
Expand Down Expand Up @@ -53,7 +53,7 @@ testPython3_4() {
compile "python3_4"
assertCaptured $LATEST_34
assertNotCaptured "security update"
assertCaptured "Installing pip 19.1.1"
assertCaptured "Installing pip 19.1.1 and setuptools 39.0.1"
# if cedar 14 and legacy binaries, fail. if cedar 14 and staging, succeed.
if [[ ! -n $USE_STAGING_BINARIES ]] && [[ $STACK == "cedar-14" ]]; then
assertCapturedError
Expand Down Expand Up @@ -89,7 +89,7 @@ testPython3_5() {
compile "python3_5"
assertCaptured $LATEST_35
assertNotCaptured "security update"
assertCaptured "Installing pip 20.0.2"
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
assertCaptured "Installing SQLite3"
assertCapturedSuccess
}
Expand All @@ -112,7 +112,7 @@ testPython3_6() {
compile "python3_6"
assertCaptured $LATEST_36
assertNotCaptured "security update"
assertCaptured "Installing pip 20.0.2"
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
assertCaptured "Installing SQLite3"
assertCapturedSuccess
}
Expand All @@ -139,7 +139,7 @@ testPython3_7() {
else
assertNotCaptured "security update"
assertCaptured $LATEST_37
assertCaptured "Installing pip 20.0.2"
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
assertCaptured "Installing SQLite3"
assertCapturedSuccess
fi
Expand Down Expand Up @@ -183,7 +183,7 @@ testPython3_8() {
else
assertNotCaptured "security update"
assertCaptured $LATEST_38
assertCaptured "Installing pip 20.0.2"
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
assertCaptured "Installing SQLite3"
assertCapturedSuccess
fi
Expand All @@ -202,7 +202,7 @@ testPypy3_6() {
else
assertCaptured "Installing pypy"
assertCaptured "$PYPY_36"
assertCaptured "Installing pip 20.0.2"
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
assertCapturedSuccess
fi
}
Expand All @@ -214,7 +214,7 @@ testPypy2_7() {
else
assertCaptured "Installing pypy"
assertCaptured "$PYPY_27"
assertCaptured "Installing pip 20.0.2"
assertCaptured "Installing pip 20.0.2 and setuptools 39.0.1"
assertCapturedSuccess
fi
}
Expand Down

0 comments on commit ca2a6b3

Please sign in to comment.