Ensure pending cases are still pending #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes a pending example for 'Swiss' since it's not pending anymore. This should make implementing pending cases a bit simpler, with better feedback.
cllns
force-pushed
the
ensure-pending-cases-are-still-pending
branch
from
8e1c8db to
6d1bbd8
Compare
|
In implementing #34, I used this change to find that |
solnic
approved these changes
Jun 18, 2021
solnic
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make implementing pending cases a bit simpler, with better feedback. Once the inflection rules implement the pending case, the test will fail and we can get a green suite by removing it from "pending".
This also removes a pending example for 'Swiss' since it's not pending anymore :) (Which is exactly the kind of thing I was hoping to find in the future)