Add source_code_uri to gemspec#16
Merged
Merged
Conversation
Contributor
|
@cllns Thanks, this is awesome! |
jodosha
approved these changes
Oct 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rubygems page for
hanami-clidoesn't link to (this) github repo.There's soon-to-be-documented metadata fields that rubygems.org uses. The one we're adding here is
source_code_uri. It adds a "Source Code" link to the rubygems.org page for the gem.Example:
https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk/aws-sdk.gemspec#L18
https://rubygems.org/gems/aws-sdk
We may want to add some of the other metadata fields that are available:
But let's see how this works; it may be enough.
We should decide which we want, and apply the same changes to all Hanami repos. 🌸
(Thanks to @bkuhlmann for pointing this out)