Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update passthrough parameters list to support ruby 3.2 #88

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Update passthrough parameters list to support ruby 3.2 #88

merged 1 commit into from
Feb 13, 2023

Conversation

hieuk09
Copy link
Contributor

@hieuk09 hieuk09 commented Feb 13, 2023

Method#parameters returns different result for * and ** from ruby 3.2, so we need to update the constant to support them.

@hieuk09
Copy link
Contributor Author

hieuk09 commented Feb 13, 2023

I updated coding style to satisfy rubocop, but still cannot make the test for ruby 2.7 pass because dry-core requires ruby 3.

@flash-gordon
Copy link
Member

Thank you!

@flash-gordon flash-gordon merged commit 39de422 into dry-rb:main Feb 13, 2023
@hieuk09 hieuk09 deleted the chore/support-ruby-3.2.1 branch February 13, 2023 10:06
@flash-gordon
Copy link
Member

Pushed 1.0.1 with the fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants