Skip to content

Use --uri from commandline over uri in an alias #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2019
Merged

Use --uri from commandline over uri in an alias #3966

merged 4 commits into from
Mar 6, 2019
+39 −16

Conversation

@greg-1-anderson
Copy link
Member

@greg-1-anderson greg-1-anderson commented Mar 4, 2019 •
edited
Loading

This is a start, but it looks like there are a few failures in the functional tests.

@greg-1-anderson
Copy link
Member Author

The tests like to insert --uri=dev by default, even if no one asked for that, for historical reasons. With this PR, that addition becomes significant, which broke some tests.

I think that the most recent commit gets us down to about one remaining failure.

@greg-1-anderson
Copy link
Member Author

Somewhat related to #3968

@greg-1-anderson greg-1-anderson mentioned this pull request Mar 4, 2019
Closed
@weitzman
Copy link
Member

weitzman commented Mar 4, 2019 •
edited
Loading

The way to do this today is:

Old: drush --uri=http://example.com
New: DRUSH_OPTIONS_URI=http://example.com drush ...

I think that should override the site alias. Or maybe leave the site alias without a URI and always use the env variable. Depends on your needs and setup.

@greg-1-anderson
Copy link
Member Author

DRUSH_OPTIONS_URI is a decent workaround (it does work fine today), but --uri on the commandline has better DX and is familiar. There's no downside to making the enhancement to take --uri from the commandline.

@greg-1-anderson greg-1-anderson added this to the drush9 milestone Mar 4, 2019
@greg-1-anderson greg-1-anderson requested a review from weitzman March 6, 2019 21:24
@weitzman
Copy link
Member

weitzman commented Mar 6, 2019

LGTM. Please close any other related issues that are still open,

@greg-1-anderson greg-1-anderson merged commit 5117a8a into master Mar 6, 2019
@greg-1-anderson greg-1-anderson mentioned this pull request Mar 6, 2019
Closed
@webflo webflo deleted the uri-option branch March 18, 2019 18:25
@lmakarov lmakarov mentioned this pull request Oct 3, 2019
Merged
@richardbporter richardbporter mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weitzman weitzman weitzman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

drush9

Development

Successfully merging this pull request may close these issues.

3 participants

@greg-1-anderson @weitzman