Skip to content

Conversation

@esolitos
Copy link

Currently it's impossible to implement such interface because in \Drush\Boot\BaseBoot::inflect():146 the wrong method is called.

When an object implements SiteAliasManagerAwareInterface it should be injected via siteAliasManager instead of setOutputAdapter which is part of VerbosityThresholdInterface

When an object implements `SiteAliasManagerAwareInterface` it should be injected via `siteAliasManager` instead of `setOutputAdapter` which is part of `VerbosityThresholdInterface`
@weitzman
Copy link
Member

LGTM. Lets leave it for @greg-1-anderson to review as well.

@weitzman
Copy link
Member

Did you deliberately target this for branch 9.5.x? We are not typically maintaining that as 9.6 release is imminent. Is the bug present in master?

@esolitos
Copy link
Author

No, 9.5.x was targeted because of the version I had locally, indeed on master is seems was fixed in #3778.

Docs still needs update, should I create a separate PR of that and close this one?

@weitzman
Copy link
Member

Yes, please edit this one or open a new one - whatever is easier.

@greg-1-anderson
Copy link
Member

I'm going to merge this because you've backported a fix from the master branch here. @esolitos: Could you please go ahead and make a new PR to get your docs example here forward-ported to the master branch?

@esolitos
Copy link
Author

esolitos commented Mar 5, 2019

Awesome, thanks for adding the backport. :)

Could you create a release to include this?
So we can use it in composer.json requirements.

@greg-1-anderson
Copy link
Member

Yeah I have been putting off making the Drush 8.2.0 release, because everyone is going to need to update to this one (for the drupal.org changes), and I'm trying to get a few more things in. I'll do it as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants