-
-
Couldn't load subscription status.
- Fork 1.1k
Allow implementing SiteAliasManagerAwareInterface.
#3950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When an object implements `SiteAliasManagerAwareInterface` it should be injected via `siteAliasManager` instead of `setOutputAdapter` which is part of `VerbosityThresholdInterface`
|
LGTM. Lets leave it for @greg-1-anderson to review as well. |
|
Did you deliberately target this for branch 9.5.x? We are not typically maintaining that as 9.6 release is imminent. Is the bug present in master? |
|
No, Docs still needs update, should I create a separate PR of that and close this one? |
|
Yes, please edit this one or open a new one - whatever is easier. |
|
I'm going to merge this because you've backported a fix from the master branch here. @esolitos: Could you please go ahead and make a new PR to get your docs example here forward-ported to the master branch? |
|
Awesome, thanks for adding the backport. :) Could you create a release to include this? |
|
Yeah I have been putting off making the Drush 8.2.0 release, because everyone is going to need to update to this one (for the drupal.org changes), and I'm trying to get a few more things in. I'll do it as soon as I can. |
Currently it's impossible to implement such interface because in
\Drush\Boot\BaseBoot::inflect():146the wrong method is called.When an object implements
SiteAliasManagerAwareInterfaceit should be injected viasiteAliasManagerinstead ofsetOutputAdapterwhich is part ofVerbosityThresholdInterface