Skip to content

Conversation

@weitzman
Copy link
Member

@weitzman weitzman commented Feb 5, 2019

This code is broken. Since migrate already handles low memory, this code no longer serves its original purpose.

@weitzman weitzman merged commit 92b2359 into master Feb 5, 2019
@weitzman weitzman deleted the no-spawn branch February 5, 2019 20:39
@markhalliwell
Copy link
Contributor

Regardless of what it was "originally" intended for, it was part of Drush's public batch API.

Removing this is not a BC "solution" for code that actually relies on this functionality (which is hard to get around in Drush due to the way batches are handled).

Instead of removing this, the affected code (referenced in the issues above), could simply not use this functionality of the API.

attrib added a commit to attrib/drush that referenced this pull request Feb 28, 2019
weitzman pushed a commit that referenced this pull request Feb 28, 2019
#3952)

* Revert "Remove respawn after 50% memory exhaustion during batch processing. (#3909)"

This reverts commit 92b2359.

* Fixing batch processing if memory limit is reached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants