Skip to content

Move stray test into functional and reclassify several classes into Unit. #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2018
Merged

Move stray test into functional and reclassify several classes into Unit. #3804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6ae003
Move stray test.
weitzman Nov 26, 2018
7a8026f
Move xhProfTest into correct subdir.
weitzman Nov 26, 2018
0064c33
Move another unit test.
weitzman Nov 26, 2018
d02cdbd
Move another unit testcase
weitzman Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 tests/RedispatchTest.php → tests/functional/RedispatchTest.php
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions tests/functional/ArgsRemapperTest.php → tests/unit/ArgsRemapperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
namespace Unish;

use \Drush\Preflight\ArgsRemapper;
use PHPUnit\Framework\TestCase;

/**
* Tests the Arguments Remapper.
*
* @group base
*/
class ArgsRemapperTest extends CommandUnishTestCase
class ArgsRemapperTest extends TestCase
{

/**
Expand All @@ -29,7 +30,7 @@ public function testCommandAliases($argv, $expected)
}

/**
* Provides argumens for ::ArgsRemapper
* Provides arguments for ::ArgsRemapper
*/
public function argsProvider()
{
Expand Down
10 changes: 3 additions & 7 deletions ...nctional/ExpandWildcardTablesUnitTest.php → tests/unit/ExpandWildcardTablesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,13 @@
* @group base
* @group sql
*/
class WildcardUnitCase extends TestCase
class ExpandWildcardTablesTest extends TestCase
{

use SqlTableSelectionTrait;

/**
* Tests drush_sql_expand_wildcard_tables().
*
* @see drush_sql_expand_wildcard_tables().
* Tests \Drush\Sql\SqlTableSelectionTrait
*/
public function testExpandWildcardTables()
{
Expand Down Expand Up @@ -49,9 +47,7 @@ public function testExpandWildcardTables()
}

/**
* Tests drush_sql_filter_tables().
*
* @see drush_sql_filter_tables().
* Tests \Drush\Sql\SqlTableSelectionTrait
*/
public function testFilterTables()
{
Expand Down
3 changes: 2 additions & 1 deletion tests/functional/XhUnitTest.php → tests/unit/XhProfTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
namespace Unish;

use Drush\Commands\core\XhprofCommands;
use PHPUnit\Framework\TestCase;

/**
* Unit tests for xhCommands
*
* @group base
*/
class XhUnitCase extends UnishTestCase
class XhProfTest extends TestCase
{

/**
Expand Down