Skip to content

Conversation

@rjgwiz
Copy link
Contributor

@rjgwiz rjgwiz commented Jul 18, 2018

Adding drush cache directory as an output field in drush status (@command core:status) as a sanity check for the new cache-directory config/DRUSH_PATHS_CACHE_DIRECTORY env variable added in #3597.

Example usage: drush status --field=drush-cache-directory

Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weitzman
Copy link
Member

I think this should be omitted from the default fields.

@weitzman
Copy link
Member

Or perhaps it should be in %paths such as drush st %paths. At least that makes sense from a config hierarchy perspective - (DRUSH.PATHS.CACHE_DIRECTORY)

@rjgwiz
Copy link
Contributor Author

rjgwiz commented Jul 18, 2018

I think this should be omitted from the default fields.

Makes sense

Or perhaps it should be in %paths such as drush st %paths. At least that makes sense from a config hierarchy perspective - (DRUSH.PATHS.CACHE_DIRECTORY)

That makes sense from a drush runtime config perspective, though the other paths all seem to be arrays and there is only one cache dir (similar to temp dir) . Also when %paths gets printed, it's labeled "Other Paths" with a list of folders. I think cache path having its own label would be very helpful. thoughts @weitzman?

@rjgwiz
Copy link
Contributor Author

rjgwiz commented Jul 19, 2018

I'm stumped on the ci error. I can't see where this change would be impacting UpdateDBTest::testFailedUpdate()

@greg-1-anderson
Copy link
Member

Those same tests passed in ci/circleci: build and ci/circleci: build_highest. Re-running build_56 to see if perhaps it was a transient failure

@weitzman weitzman merged commit a719fa4 into drush-ops:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants