-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Site alias location filters #3602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… alias name that is based on the name of the folder the alias file is stored in.
|
Motivation:
Beyond these use cases, maintaining the user experience of being able to address a site as either See the above-referenced PR for implementation. Unlike the previous "alias groups" implementation, this version does not add much additional complexity to the site alias package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this PR. Feel free to merge when you are ready.
My preference is for aliases to stay simple both in their code and in their mental model. As you mentioned, the code changes here and in consolidation/site-alias#1 are not too onerous.
However, I feel like we were making progress with the message that sites should check their aliases into their codebase in /drush. That gives every team member the same experience when running remote commands from their local. It also lets the alias format vary as long as it matches the drush thats in the same repo. so the user controls everything in the repo and can upgrade with confidence. this story gets slightly muddled with this PR as ISPs are going offer aliases again outside of the repo. now we have a versioning mismatch potential, and we have a 'but how do i run commands on my remote sites' problem.
There is a real tug of war going on between 'drush for site owners' and 'drush for isps'. this PR s for the ISPs IMO. same for the "drush8 as global launcher" PR. not sure how to resolve the tension.
examples/example.site.yml
Outdated
| # Such alias files may still be referenced by their shorter name, e.g. | ||
| # `@example.dev`. | ||
| # | ||
| # If you run the command `drush core:init`, this configuration will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sentence is awkwardly placed. i'm not sure what 'this' refers to.
|
Yeah, checking aliases into the site requires a local working copy of the sites codebase to work. The use case of not having a local working copy is more of a convenience for "drush for isps". The "Download Drush Aliases" button is popular. I'll fix up the text in example.site.yml that follows the text I added. |
…h core:init' command in example.site.yml.
|
I updated this PR to use site-alias:^1, and also corrected the documentation. Note that users do not get the If we do that, then is adding a global |
|
I think we should try to keep one example file. Lets try over time, in the same file, to fence off the Advanced info. |
|
I'll merge here for now and try adding an "ADVANCED" section at the bottom later. |
Allow site aliases to be referred to by a 'location' component of the alias name that is based on the name of the folder the alias file is stored in.
See the PR at consolidation/site-alias#1