Skip to content

Conversation

@greg-1-anderson
Copy link
Member

Replaces #3333

@greg-1-anderson
Copy link
Member Author

PHP 7.1 is pretty similar to 7.0, so I did not add it here.

@greg-1-anderson
Copy link
Member Author

Maybe we should also skip composer-highest on php 5.6?

I kind of hate all of the excludes, but I don't think that naming all of the permutations to run is much of an improvement either.

@greg-1-anderson
Copy link
Member Author

Or, we could run all of the functional tests on one version of php only, and pick a third testing service (codeship?) to run them on. 😝

@greg-1-anderson
Copy link
Member Author

I didn't look for warnings in the test output, but the tests are all green, at least.

Codeship only provides 100 builds per month on the free plan. I looked at Shippable briefly, but couldn't figure out how to start a build on an org (drush-ops). It's authorized for drush-ops, but it doesn't show up in subscriptions.

Maybe what we have is okay.

@weitzman
Copy link
Member

PR looks good to me.

@greg-1-anderson greg-1-anderson merged commit 28e9e5d into master Jan 31, 2018
@weitzman weitzman deleted the php-72-isolation branch December 13, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants