Skip to content

Conversation

@pfrenssen
Copy link
Member

Partially fixes #3296.

When performing multiple database updates in a row, the individual messages that are returned by the update hooks are output in the log after all the updates have finished. This might give the impression that the updates have been performed in parallel or out of order, and this might be misleading for system administrators that are investigating a failed update.

Currently the output might look like this:

 [notice] Executing woot_update_8101
 [ok] Performing woot_update_8101
 [notice] Executing woot_update_8102
 [error]  8102 error 
 [ok] Performing woot_update_8102
 [notice] woot_update_8101 <----- out of order
 [error]  Failed batch process: woot_update_8102 
 [error]  Finished performing updates. 

@pfrenssen
Copy link
Member Author

The test shows that the update message is displayed out of order. Now let's fix it.

@pfrenssen pfrenssen mentioned this pull request Jan 16, 2018
@claudiu-cristea
Copy link
Member

Discussed with @pfrenssen and I will review this PR tomorrow morning so it can be quickly ready for the 9 stable release.

@claudiu-cristea
Copy link
Member

claudiu-cristea commented Jan 18, 2018

I rerolled the PR. Tested on a big project with a lot of updates. The order of log messages is OK. We have also tests, what else. @weitzman, +1 for merging.

@weitzman
Copy link
Member

Merged by #3310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve logging when performing site updates

3 participants