Processing configuration files recursively. #3288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
requested changes
Jan 3, 2018
Member
greg-1-anderson
left a comment
greg-1-anderson
left a comment
There was a problem hiding this comment.
LGTM, but I think there should be a test where some site-specific drush.yml includes a.drush.yml which includes b.drush.yml which includes a.drush.yml. Then, confirm that values set in all the config files are available, and (indirectly) no infinite loop happened.
grasmash
force-pushed
the
issue-3287-config
branch
from
9c895c5 to
e7b2982
Compare
grasmash
force-pushed
the
issue-3287-config
branch
from
45b3e52 to
2300ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.