Allowing files by any name to be imported via -c option. #3283
Conversation
src/Config/ConfigLocator.php
Outdated
| 'drush.yml', | ||
| 'config/drush.yml', | ||
| ]; | ||
| $this->addConfigCandidates($processor, $loader, $dirs, $candidates); |
There was a problem hiding this comment.
Might be cleaner to combine addConfigCandidates functionality (sans adding) to separateFilesAndDirs method. Then, the later could just return a list of files, which could all be added together via addConfigFiles.
I could also support the current implementation if there's any problem/disagreement with the suggested refactor.
grasmash
force-pushed
the
issue-3279-config-2
branch
from
cc192a3 to
d19971a
Compare
| foreach ($paths as $path) { | ||
| if (file_exists($path)) { | ||
| if (is_dir($path)) { | ||
| $dirs[] = realpath($path); |
There was a problem hiding this comment.
If you pass in $candidates to this function then you could call $this->identifyCandidates($dirs, $candidates); here (or at the end of this function). This would allow you to keep $dirs private to this method and return only $files.
There was a problem hiding this comment.
This improvement would of course imply a renaming of this method.
grasmash
force-pushed
the
issue-3279-config-2
branch
from
10beeb3 to
70dc2d7
Compare
grasmash
force-pushed
the
issue-3279-config-2
branch
from
46367ec to
70dc2d7
Compare
|
LTGM - thanks for doing the extra complexity-reducing refactors. |
2 participants
No description provided.