Skip to content

Fix infinite recursion when empty path is provided to drush_mkdir #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix infinite recursion when empty path is provided to drush_mkdir #2864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions includes/filesystem.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,12 @@ function drush_move_dir($src, $dest, $overwrite = FALSE) {
* halted if the required directory cannot be created.
*/
function drush_mkdir($path, $required = TRUE) {
if (!is_string($path) || $path === '') {
if (!$required) {
return FALSE;
}
return drush_set_error('DRUSH_INVALID_DIRECTORY_PATH', dt('Unable to create directory. Invalid path provided.'));
}
if (!is_dir($path)) {
if (drush_mkdir(dirname($path))) {
if (@mkdir($path)) {
Expand Down