Skip to content

Conversation

@greg-1-anderson
Copy link
Member

Let's see if it works.

@greg-1-anderson
Copy link
Member Author

@weitzman: Seems to work. Do we want to still test EOL branches, like 6.x and 5.x? What about 8.0.x? Any others?

@weitzman
Copy link
Member

weitzman commented Jan 9, 2016

We had this before (its still in 7.x branch). I think I removed it when messing around with drush.phar deployment. Perhaps the branches directive stopped testing of tags and thus stopped auto-upload of the phar. I'm a bit wary of putting this back.

@greg-1-anderson
Copy link
Member Author

Hm. The docs on deploy say that deploy tasks run on tags only, so the branches config should not affect that. The branches configuration allows regular expressions; don't know that that helps us.

Seems like it should work, but up to you whether or not you want to merge it.

@weitzman
Copy link
Member

weitzman commented Jan 9, 2016

Lets leave as is. I ran into issues like travis-ci/travis-ci#2111.

@weitzman weitzman closed this Jan 9, 2016
@greg-1-anderson
Copy link
Member Author

Okay, so it looks like branches inadvertently applies to tags as well. We could use a regex that matched N.N.N, and it would probably work.

Maybe I'll reopen later with an updated patch if I test this on some other repo first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants