-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a hook_drush_sitealias_alter, with documentation. #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hook_drush_sitealias_alter, with documentation. #1279
Conversation
…nt' element in site aliases, for eventual removal (probably in Drush 8).
|
'parent' might be a seldom-used feature. If we think folks aren't using it much, we could just flat-out remove it in Drush 7 and be done with it. |
|
I am using the 'parent' elemtn quite extensively in drush aliases. It allows us to define a server environment and have all sites residing on that server inherit things like the remote-host and root values. |
|
Does the 'parent' complicate the code a lot? |
|
To follow up on my tweet: If you are using the 'parent' feature, read the patch and see if the policy file solution works well for your use-case. The thing we are trying to change here is transitioning to loading alias files from yaml rather than loading them in code. |
|
Acquia uses |
|
Probably deprecate this in Drush7, remove in Drush8, I'm guessing, then. We'll also have to consider if the submitted patch is too noisy for folks. :) |
|
I mis-spoke above: there is no real requirement to remove 'parent' if we switch to yaml alias files. We could keep 'parent', and commit just the alter hook. But I know that moshe has wanted to get rid of 'parent' for a while (see #975) |
|
I really like this PR. It moves the complexity of parents to a policy. It is valuable, independant of the transition to YAML site alias files. The core issue is that greg is the sole person who works on backend and site aliases. Much of the code others could maintain but some is gnarly and rarely used; I think 'parent' is in that category. Drush project is too crucial to ignore this SPOF problem. |
|
Shall we commit it as-is, then, with 'parent' deprecated and noisy, but still functional? |
|
I think we can turn down the log level a notch and then merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's usually advised to use array_key_exists() for arrays instead.
|
Deprecated: http://en.wiktionary.org/wiki/deprecated |
|
I turned the log level down to 'debug' and merged. End effect: 'parent' element is now deprecated in Drush 7, although it still works just fine, and the deprecation warnings are only visible in "debug" mode. |
Deprecate 'parent' element in site aliases, for eventual removal (probably in Drush 8).