Drush 9 sql-sync does not use ssh-options from target alias during database import

[gaelg]

Looks like it ignores at least paths.drush-script and ssh.options (-vvv shows a wrong ssh command). We use aliases on sql-sync for getting content from prod back to dev easily. We can't use them currently with Drush 9 (recommended for Drupal 8.4).

[weitzman]

The master branch supports both of those. A new beta should go out in next couple of days. Note that ssh-options should be nested under 'options' per example.aliases.yml

[gaelg]

Yes, I tested against the master branch, it's not working. The two alias options I gave work well for other commands such as drush status, but not for sql-sync. I guess this command is special because the syntax is drush command @alias1 @alias2 and not drush @alias command.

[weitzman]

Thanks for the report. Please post output with --debug, output of drush sa @alias1 and drush sa @alias2.

[gaelg]

`drush sa @test
'@test.test':
host: my.domain.fr
paths:
drush-script: /my/root/drupal-drush9/vendor/drush/drush/drush
root: /my/root/drupal-drush9/web
user: insite

ggosset@ggosset-desktop ~/workspace/insite_drupal (drush9 *=) $ drush sa @docker
'@docker.docker':
host: localdocker
ssh:
options: '-p 2200'
root: /var/www/html/web
uri: 'http://localdocker:8000'
user: www-data

ggosset@ggosset-desktop ~/workspace/insite_drupal (drush9 *=) $ drush --debug -y sql-sync @test @docker
Using the Drush script found at /home/ggosset/workspace/insite_drupal/vendor/drush/drush/drush using pcntl_exec
[bootstrap] Bootstrap to none [0.16 sec, 7.09 MB]
[bootstrap] Drush bootstrap phase 0 [0.16 sec, 7.15 MB]
[bootstrap] Try to validate bootstrap phase 0 [0.16 sec, 7.15 MB]
[command] Backend invoke: ssh -o PasswordAuthentication=no insite@my.domain.fr 'drush --backend=2 --verbose --debug --yes --root=/my/root/drupal-drush9/web core-status 2>&1' 2>&1 [0.16 sec, 7.2 MB]
[info] ssh -o PasswordAuthentication=no insite@my.domain.fr 'drush --backend=2 --verbose --debug --yes --root=/my/root/drupal-drush9/web core-status 2>&1' 2>&1 [0.16 sec, 7.2 MB]
[error] The command could not be executed successfully (returned: bash: drush : commande introuvable
, code: 127) [0.4 sec, 7.2 MB]
[command] Backend invoke: ssh -o PasswordAuthentication=no www-data@localdocker 'drush --backend=2 --verbose --debug --yes --root=/var/www/html/web --uri=http://localdocker:8000 core-status 2>&1' 2>&1 [0.4 sec, 7.2 MB]
[info] ssh -o PasswordAuthentication=no www-data@localdocker 'drush --backend=2 --verbose --debug --yes --root=/var/www/html/web --uri=http://localdocker:8000 core-status 2>&1' 2>&1 [0.4 sec, 7.2 MB]
[error] The external command could not be executed due to an application error. [0.41 sec, 7.2 MB]
[error] The command could not be executed successfully (returned: ssh: connect to host localdocker port 22: Connection refused
, code: 255) [0.41 sec, 7.2 MB]
[error] Error: no database record could be found for source @test [0.41 sec, 7.22 MB]
ggosset@ggosset-desktop ~/workspace/insite_drupal (drush9 *=) $
`

You can also get the results of drush status in #3045. By the way, I added ssh to my docker container, it's not docker-philosophy-compliant but it's easier to integrate with drush aliases. And "localdocker" points to 127.0.0.1 in my /etc/hosts.

[greg-1-anderson]

It's on our roadmap to support direct docker exec via aliases for drush @alias command. If you expect drush rsync @a1 @a2 to work, then you are going to need ssh anyway, so I would disagree with saying categorically that adding ssh to a Drupal container is not "docker-philosphy-compliant". Add the things to your container that you need. We're also in favor of more efficient ways of doing things, though, so if you would like to contribute an sql-sync &/or rsync command that uses docker exec and the shared filesystem to operate, by all means do.

The drush rsync @a @b command does not yet merge the alias definition into the active context. That is also a planned feature, and is going to be necessary before any sql-sync or rsync implementations are going to work on a docker container.

[gaelg]

All right. Do you mean that my command can't work currently because it's a docker container and docker is not yet supported for Drush 9? Or is it an unrelated comment? Because I think the way I use it (SSH into Docker) make drush docker-agnostic. My docker container could instead be any remote server accessed through SSH, and my command would break though.

So is this issue a real bug? A known issue currently in a TODO list? A consequence of #3045? A mis-usage?

[greg-1-anderson]

This is unrelated to #3045.

The scenario described in this issue does not work because drush rsync @a @b does not copy options in those aliases such as ssh-options into any context that would allow them to influence the behavior of backend invoke or rsync or etc., so any rsync or sql-sync scenario that requires custom options will not work. There is no PR for this feature; this issue is sufficient for tracking; it's already part of the "Nine" project, which is our official TODO list.

#1910 is the issue for docker exec.

[gaelg]

Understood, thank you for your clear answer and your work on drush 9.

[greg-1-anderson]

Working on this in #3075. Command-specific options are working, but other things (drush-script, ssh-options, etc.) probably still need work.

[greg-1-anderson]

@gaelg and anyone else tracking this issue: Please try #3075 and see if it meets your use-case. Even more importantly:

• If we deleted https://github.com/drush-ops/drush/pull/3075/files#diff-f9ab80007ea4f0d9f488a2e87fb7215dR270 and replaced it with $aliasOptions = [];, would it still meet your use-case?
• If we deleted https://github.com/drush-ops/drush/pull/3075/files#diff-f9ab80007ea4f0d9f488a2e87fb7215dR272 and the if block that followed, would it still meet your use-case?

It is our intention that ssh-options and drush-script from alias files should propagate to remote commands, but it is unclear at this time exactly which features in Drush 8 folks are using to control this at the moment. We are discussing removing some features that may be unneeded, as specified above.

[gaelg]

@greg-1-anderson It does not work because the SSH connection to @test takes the SSH options from @docker (port 2200):

drush --debug -y sql-sync @test @docker Drush Launcher Version: 0.4.2 ROOT: /home/ggosset/workspace/insite_drupal DRUSH VERSION: 9 DRUPAL ROOT: /home/ggosset/workspace/insite_drupal/web COMPOSER ROOT: /home/ggosset/workspace/insite_drupal VENDOR ROOT: /home/ggosset/workspace/insite_drupal/vendor [bootstrap] Bootstrap to none [0.14 sec, 8.24 MB] [bootstrap] Drush bootstrap phase 0 [0.14 sec, 8.24 MB] [bootstrap] Try to validate bootstrap phase 0 [0.14 sec, 8.24 MB] [command] Backend invoke: ssh -p 2200 insite@my.domain.fr '/my/root/drupal-drush9/vendor/drush/drush/drush --backend=2 --verbose --debug --yes --root=/my/root/drupal-drush9/web core-status 2>&1' 2>&1 [0.14 sec, 8.25 MB] [info] ssh -p 2200 insite@my.domain.fr '/my/root/drupal-drush9/vendor/drush/drush/drush --backend=2 --verbose --debug --yes --root=/my/root/drupal-drush9/web core-status 2>&1' 2>&1 [0.14 sec, 8.26 MB] ^C ggosset@insite-asus ~/workspace/insite_drupal $