Repository navigation
feat: add secure password reset and admin recovery links - #452
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add forgotten-password recovery by username or email, plus an admin-generated reset-link fallback when mail is unavailable.
Evidence
After: Regression tests pass, including the real PostgreSQL concurrency test, which fails with the original method substituted in memory.
git diff --checkpassed.npm auditon this branch reports 11 existing high-severity findings in frontend tooling dependencies; no dependency files changed. Main already addresses these in fix: patch braces stack-exhaustion DoS (CVE-2026-93687) #451.Merge Danger
Door: two-way
Apply Alembic migration
20261016_0097before deploying the backend. Self-serve reset requires mail configuration andRELAY_PUBLIC_WEB_URLorRELAY_PUBLIC_BACKEND_URL; admin-issued links work without mail. Completion revokes Account sessions and requires a fresh sign-in. Partial mail configuration now fails startup even with the waitlist disabled.Blast Radius: authentication
Affects both auth stores, login/recovery pages, admin user editing, and the shared transactional mailer. Daemon credentials are unaffected.