Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitor volume adjustment #733

Merged
merged 11 commits into from
Jul 14, 2024
Merged

Add monitor volume adjustment #733

merged 11 commits into from
Jul 14, 2024

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Jul 13, 2024

Resolves #732 by adding new right-click menu items for adjusting monitoring volume under PTT and Voice Keyer. Example:

image

image

Clicking outside of the box that appears will close it. Additionally, updates here are live (i.e. if you're transmitting, you can hear the volume changing as you adjust the slider).

@barjac
Copy link

barjac commented Jul 13, 2024

Very nice!
However the slider widget melts into the display elements behind it especially when the main window is using multiple widget columns either side of the scope.

Is it possible to put a border line around it?
Maybe even dim the whole display behind it while it has focus?
Or maybe give it a different background colour or invert it's foreground/background?

Screenshot_20240713_104349a

@Tyrbiter
Copy link

The only thing I will mention as a minor thing, the new monitor settings and code have the word Monitor typo'd as Montior, it's not urgent but probably best to fix it sooner rather than later.

Will report on the actual function of the change later.

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 13, 2024

Is it possible to put a border line around it? Maybe even dim the whole display behind it while it has focus? Or maybe give it a different background colour or invert it's foreground/background?

There's a border around it now as of 09b7275.

The only thing I will mention as a minor thing, the new monitor settings and code have the word Monitor typo'd as Montior, it's not urgent but probably best to fix it sooner rather than later.

Fixed.

@barjac
Copy link

barjac commented Jul 13, 2024

Yes that looks and works fine for me now.
Nice job Mooneer! :)

@tmiw tmiw merged commit 9ff4688 into master Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relative volume settings in config for both transmit monitors
3 participants