Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle high sample rate audio devices. #668

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Jan 23, 2024

This PR improves the behavior of FreeDV when using audio devices at higher sample rates (e.g. >48000) and channel counts (e.g. the 4 channel minimum the Focusrite Scarlett has on Windows). Basically, the following in the code's changed:

  1. Remove the arbitrary 48 kHz limitation in the main RX and TX processing loops.
  2. Add logic to detect the minimum number of channels for an audio device (PortAudio only; currently hardcoded to 1 on PulseAudio/pipewire).
  3. Remove hardcoding of the two channel limit in the audio handling callback.
  4. Fix any bugs encountered during testing of the above.

@tmiw tmiw merged commit b7bb816 into master Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant