Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary recreation of resamplers in analog mode. #661

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Jan 20, 2024

Resolves #658 by fixing a bug where the AudioPipeline that does not have any steps inside it was unnecessarily recreating the output ResampleStep every time it processed a 20ms chunk of audio. This causes the state of the resampler to be lost, resulting in scratchy or dropped audio.

Note that the following must be true in order to observe this issue:

  1. The sample rate for the digital input device ("From Radio to Computer") needs to be different than for the analog device ("From Computer to Speakers/Headphones"), and
  2. FreeDV must be in analog mode. (Normal digital operation goes through a different flow inside the overall audio pipeline which doesn't seem to be affected by this issue.)

@tmiw tmiw merged commit 0176fe8 into master Jan 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scratchy audio in Analog mode
1 participant