Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow display and entry of frequencies in KHz #621

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Allow display and entry of frequencies in KHz #621

merged 4 commits into from
Dec 14, 2023

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Dec 12, 2023

Resolves #583 by adding a new configuration option to allow display and entry of frequencies in KHz.

@Tyrbiter
Copy link

This seems to work OK, but should the entry list in the Options dialog also change to kHz when this option is selected?

@tmiw
Copy link
Collaborator Author

tmiw commented Dec 12, 2023

This seems to work OK, but should the entry list in the Options dialog also change to kHz when this option is selected?

It should already be doing that (I tested last night to be sure), albeit you need to push Apply or OK first.

@Tyrbiter
Copy link

OK, yes, seems to work. If a value already exists in the entry box, say 1.997MHz, then this turns into 1.997kHz after changing the setting and applying it. Might be a bit confusing.

@tmiw
Copy link
Collaborator Author

tmiw commented Dec 13, 2023

OK, yes, seems to work. If a value already exists in the entry box, say 1.997MHz, then this turns into 1.997kHz after changing the setting and applying it. Might be a bit confusing.

Should be fixed now :)

@Tyrbiter
Copy link

OK, yes, seems to work. If a value already exists in the entry box, say 1.997MHz, then this turns into 1.997kHz after changing the setting and applying it. Might be a bit confusing.

Should be fixed now :)

And indeed it is, thanks.

@tmiw tmiw merged commit 1b8d720 into master Dec 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for frequency entry in KHz instead of MHz
2 participants