-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force all left hand side boxes the same width. #613
Conversation
Not sure why, but seeing a build error now, didn't happen with my initial build of 1.9.6-devel: /home/bdm/rpmbuild/BUILD/freedv-gui-1.9.6/src/rig_control/HamlibRigController.cpp: In static member function ‘static void HamlibRigController::InitializeHamlibLibrary()’: |
Looks like Mike changed some stuff in hamlib: https://github.com/Hamlib/Hamlib/blob/master/include/hamlib/rig.h |
Unfortunately, fixing this for 4.6~git breaks it for 4.5.5. I'm very hesitant to force usage of the former given that it's not exactly stable. Let me see if I can detect 4.6 somehow during compile time. |
I created a Hamlib issue to see if we can get that reversed (or if Mike can recommend a workaround that will work on both 4.5 and 4.6). |
Looks like there'll be a fix on Hamlib's side, but since it'll also require FreeDV changes, I created #614 to track this. |
OK, I now have a build of hamlib-4.6~git that contains Mike's fix. When you have new code to test I will try it out. |
#615, but I was able to check here on 4.5.5 and 4.6 and both worked fine with that change. Will merge into master as soon as GitHub finishes CI. |
Now have a build with current code @tmiw, it is all looking very good. |
This resolves #610 by doing the following: