Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decimal separator force to "." dot for frequencies translation on… #560

Closed
wants to merge 1 commit into from
Closed

Add decimal separator force to "." dot for frequencies translation on… #560

wants to merge 1 commit into from

Conversation

Artemia76
Copy link

On French Computer, locale use the comma as decimal separator. This make rig exchange translate frequencies without the decimal part { 14,236 -> 14.000) } by using wxWidget::Format when using Frequency reporter

I add a small check and force locale for numeric decimal separator to dot "." to avoid

@tmiw
Copy link
Collaborator

tmiw commented Oct 2, 2023

Thanks for this code change. I'm not comfortable with just forcing C locale for number processing, especially when this behavior would likely be different from other applications on this system. I created an alternative PR (#561) that updates the frequency list to display properly for the user's current locale. For example, with this PR and forcing LANG to be fr_FR.utf8, the frequency list now looks something like this:

Screenshot 2023-10-01 at 11 54 23 PM

Let me know how that works for you. If that solves your issue, we'll go ahead and close this PR.

@tmiw
Copy link
Collaborator

tmiw commented Oct 3, 2023

Looks like #561 is good so I'm going to go ahead and close this PR. Let me know if you have any questions.

@tmiw tmiw closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants