Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements for "On Top" menu option #549

Merged
merged 3 commits into from
Sep 21, 2023
Merged

UX improvements for "On Top" menu option #549

merged 3 commits into from
Sep 21, 2023

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Sep 21, 2023

Resolves #546 by doing the following:

  1. On Linux (or any other platform using GTK), hide the "On Top" menu option as it's not reliable (note: support was even removed entirely in GTK4 for this reason).
  2. For other platforms, rename "On Top" to "Keep On Top" and indicate whether it's enabled via a checkmark next to the menu item. Example below:
Screenshot 2023-09-20 at 10 09 39 PM

@tmiw tmiw merged commit b21c8cb into master Sep 21, 2023
@barjac
Copy link

barjac commented Sep 21, 2023

I think the common term for this is 'Keep above others' as in KDE Plasma5.

@tmiw
Copy link
Collaborator Author

tmiw commented Sep 21, 2023

Windows calls it "Always on Top", IIRC. I don't know if macOS uses the same or different terminology for this. We'd probably want to use one of those if we were to use something other than "Keep On Top".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File->On Top does not seem to do anything
2 participants