Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate max values for each slider type in the Filter dialog. #485

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Jul 26, 2023

Resolves #463 by using separate ranges for each slider type on the Filter dialog. This has the effect of making sure a single press of the arrow key (when a slider has focus) adjusts a single "unit" on the selected control, hopefully making it easier to make filter selections.

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 26, 2023

@barjac, @Tyrbiter, let me know how this change works for you. I think that as long as you can return to a previous value by using the arrow keys, we should be fine. 👍

@Tyrbiter
Copy link

It looks OK to me now, although the click and drag interface is odd on Fedora I suspect that is a wxWidgets bug of some kind. The arrow keys work, but there is nothing to cue the user to use them unless I've missed something.

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 26, 2023

It looks OK to me now, although the click and drag interface is odd on Fedora I suspect that is a wxWidgets bug of some kind. The arrow keys work, but there is nothing to cue the user to use them unless I've missed something.

I'm not sure there's supposed to be anything obvious to let people know you can use the keyboard to adjust sliders. Might be one of those things you just know if you're used to keyboard input instead of using the mouse. /shrug

@Tyrbiter
Copy link

Yeah, which is why I suggested a spin box a while ago, but the sliders do look much nicer.

Adding a sentence to the manual would make sure that we can deny any problems plausibly ;-)

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 26, 2023

Adding a sentence to the manual would make sure that we can deny any problems plausibly ;-)

Done 👍

@tmiw tmiw merged commit 2f74a14 into master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter setting sliders too aggressive (1.18.12 pre)
2 participants