Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modifying the drop down frequency list. #460

Merged
merged 16 commits into from
Jul 9, 2023

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Jul 5, 2023

Per feedback in #432, this PR adds the ability for users to modify the frequency list in the lower right hand corner of the main window (via Tools->Options->Rig Control). The new UI looks as follows:

Screenshot 2023-07-04 at 8 25 11 PM

Note: PR #457 must merge before this can as the code here depends on that PR.

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 5, 2023

@Tyrbiter
Copy link

Tyrbiter commented Jul 5, 2023

I have this built and installed now.

About the frequency editing, I suggest expanding the entered number to 4 decimal places if it's not entered to that precision. Otherwise it seems to work, I have added, removed and reordered some extra frequencies.

Is it possible to remove a frequency in the original list? I have not tried that.

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 5, 2023

Is it possible to remove a frequency in the original list? I have not tried that.

Yep 👍

@Tyrbiter
Copy link

Tyrbiter commented Jul 5, 2023

Is it possible to remove a frequency in the original list? I have not tried that.

Yep 👍

OK, all seems to be working well. I see that the .freedv settings file is updating and saving as it should too.

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 6, 2023

About the frequency editing, I suggest expanding the entered number to 4 decimal places if it's not entered to that precision.

Done. 👍

@Tyrbiter
Copy link

Tyrbiter commented Jul 8, 2023

I have also merged in the PRs #461 and #462, everything is working very nicely together.

I think it would be useful to remember the size and position of the Audio Config window, the expanded name column hides the other columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants