Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always have the Mode box take up the maximum size. #347

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Feb 21, 2023

Resolves #346 by preventing the Mode box from resizing.

@Tyrbiter
Copy link

The Others modes don't show up with the expanded selection, I'm guessing that the last edit at topFrame.cpp:673 needs to be non-empty :)

@tmiw
Copy link
Collaborator Author

tmiw commented Feb 21, 2023

The Others modes don't show up with the expanded selection, I'm guessing that the last edit at topFrame.cpp:673 needs to be non-empty :)

Yep. Weirdly, it worked fine on my Mac without that, just not on Linux.

@Tyrbiter
Copy link

There was something like that in a different PR fairly recently, not sure why but the MacOS wxWidgets code is just a bit different.

I currently have 2020C built into my local freedv-gui, with that entry there the value needed in topFrame.cpp:374 is 280 to prevent the box changing size when the list is expanded. At some point when the list size stabilises I suppose this should be optimised.

@tmiw
Copy link
Collaborator Author

tmiw commented Feb 22, 2023

There was something like that in a different PR fairly recently, not sure why but the MacOS wxWidgets code is just a bit different.

I currently have 2020C built into my local freedv-gui, with that entry there the value needed in topFrame.cpp:374 is 280 to prevent the box changing size when the list is expanded. At some point when the list size stabilises I suppose this should be optimised.

Yeah, I'll have to update this in ms-2020c for sure.

Anyway, thanks! Will merge since there don't seem to be any other issues.

@tmiw tmiw merged commit df8a17a into master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mode box in GUI changes columns each time Others is expanded/contracted
2 participants