Skip to content

Add a more type safe way of registering gauges in 5.0.x #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joschi merged 1 commit into from
Nov 18, 2022
Merged

Add a more type safe way of registering gauges in 5.0.x #2792

joschi merged 1 commit into from
Nov 18, 2022

Conversation

@DanyBv
Copy link

@DanyBv DanyBv commented Aug 15, 2022 •
edited
Loading

Problem: Missing registerGauge method in MetricRegistry (5.0.x)
Solution: Add the registerGauge method to MetricRegistry (c1d0fb9)
Result: The registerGauge method is added to MetricRegistry

@DanyBv DanyBv requested review from a team as code owners August 15, 2022 17:11
@gitpod-io
Copy link

gitpod-io bot commented Aug 15, 2022

@joschi joschi added this to the 5.0.0 milestone Nov 18, 2022
@joschi joschi added the feature label Nov 18, 2022
joschi
joschi approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanyBv Thanks a lot for your contribution! ❤️

@joschi joschi merged commit 67d7c0c into dropwizard:release/5.0.x Nov 18, 2022
@DanyBv DanyBv deleted the release/5.0.x-registerGauge branch November 29, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joschi joschi joschi approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@DanyBv @joschi