Void argument routes should not require null

[krieb]

When calling an endpoint that does not accept any parameters (e.g. usersGetCurrentAccount()), null must be passed as an argument. This is somewhat confusing and the error message returned when you forget to pass null doesn't help either:

> dbx.usersGetCurrentAccount()
POST https://api.dropboxapi.com/2/users/get_current_account 400 (Bad Request)
Error in call to API function "users/get_current_account": request body: could not decode input as JSON
> dbx.usersGetCurrentAccount(null)
lib$es6$promise$promise$$Promise {xot8798dunmi: 2, _state: undefined, _result: undefined, _subscribers: Array[0]}

We should default to sending null when no argument is supplied.

[braincore]

Legit catch.

[rileytomasek]

thanks for catching this @krieb

[bobmoff]

The issue still remains, in the typescript definitions.

[greg-db]

@bobmoff Apologies for the delay, and thanks for the note. We'll look into it.

[pran1990]

@jvilk a seemingly simple fix here is to remove the arg: void from https://github.com/dropbox/dropbox-sdk-js/blob/master/generator/typescript/dropbox.d.ts#L1484 (and any other functions that don't have an input). Can you advice if that is the correct thing to do?

[jvilk]

@pran1990 Yes, that is correct.

Note that that file is auto-generated from the stone specification, which specifies that that route takes an argument of type 'void'.

You should change the TypeScript stone generator to special-case the output of routes that take a void argument.

Here's an (untested) change to the generator that should work (forgive any syntax errors / things that aren't best practice; I don't often write Python code):

        arg_data_type = fmt_type(route.arg_data_type)
        if route.arg_data_type == "void":
                self.emit('public %s(): Promise<%s>;' %
                           (function_name, fmt_type(route.result_data_type)))
        else:
                self.emit('public %s(arg: %s): Promise<%s>;' %
                          (function_name, arg_data_type, fmt_type(route.result_data_type)))

Hope that helps!

[alexandrtovmach]

It's already fixed issue, and that's should be closed

[greg-db]

Apologies, the original issue was resolved, but we had this still open for the same issue in TypeScript.

[rogebrd]

Newest version should fix the issue.

[greg-db]

This should be fixed for TypeScript as of the latest version, v7.0.0.