Fixed Errors! #1209
Fixed Errors! #1209
Conversation
There was a problem hiding this comment.
This looks correct to me, as mission_item is deprecated. @peterbarker Do you know how the CI works - not reporting anything on this.
…ere was no heartbeat for 30 seconds.
…ere was no heartbeat for 30 seconds.
|
@morzack What do you think about this one? |
hamishwillee
requested review from
morzack and
peterbarker
and removed request for
hamishwillee
|
@ShafiqSadat I'm not going to merge this. That has to be done by someone with more technical knowledge. I have requested Peter and John, but this will have to await their attention. |
There was a problem hiding this comment.
I've been wanting to do something like this twine thing for a very long time :-)
There are good changes in here, but you've got several unrelated changes mixed into the one PR, making merging anything difficult.
You should also only have a single commit per logical change, and commit messages which actually say what logical change has been made.
dronekit/__init__.py
Outdated
| @@ -816,10 +816,10 @@ def __len__(self): | |||
| def _update_channel(self, channel, value): | |||
| # If we have channels on different ports, we expand the Channels | |||
| # object to support them. | |||
| channel = int(channel) | |||
There was a problem hiding this comment.
This change is strange
dronekit/mavlink.py
Outdated
| @@ -245,7 +248,8 @@ def mavlink_thread_in(): | |||
| ) | |||
|
|
|||
| except APIException as e: | |||
| self._logger.exception('Exception in MAVLink input loop') | |||
| #self._logger.exception('Exception in MAVLink input loop') | |||
| self._logger.warning('%s' % str(e)) | |||
Fixes #1208