Escapes outside of variable substitution - #27
Conversation
|
Sounds valid for me, now code got to be fixed :) |
459e1fa to
7b055d1
Compare
|
I added a few more tests cases and updated so only the |
7b055d1 to
4984f7a
Compare
|
@tboerger gentle ping. If there is a better approach, happy to adjust |
|
thanks @jsturtevant. I think this looks good. I always felt like we had to do some extra escaping in Drone (which uses this library) and it always felt off ... this bug probably explains why :) I think fixing this bug might break some existing Drone yaml files that are compensating for this escaping bug you identified. Perhaps this is a good time to bump this to a 2.0 go module version. Thoughts @tboerger ? |
|
@tboerger @bradrydzewski any further thoughts here? |
|
Bumping the version sounds valid to me. This could be added to Drone 2.0 in that case. |
|
Is bumping the version something I need to do in this PR or is that a follow up? Would like to get this update in so we can unblock the capi scenario it is used in: kubernetes-sigs/cluster-api#4016 |
|
hey James, apologies for not being more responsive. Yes, if you could help bump the version number as part of this pull request that would be great. I also think having more people involved and able to merge would be great, and would like to grant you maintainer access, if you are interested ... that way you can help push through time sensitive pull requests related to kubernetes. |
|
@bradrydzewski I've updated the module version. Regarding the maintainer access, I could help out. Do you have any docs on your release process or other things like that? Is there a communication channel you hang out in for drone (i.e. slack or something similiar)? |
|
@jsturtevant thanks for the contribution. we are working on making Drone more of an open community so please bear with us; we do not have a lot of process or documentation in place yet. @tphoney any advice on what we can / should put in place here? |
…cters causes failure (#793) * fix(compiler): update envsubst to v2 Use the implementation made upstream in drone/envsubst#27 to fix escape sequence handling to prevent yaml parsing to fail due to invalid escape sequences. Issue: go-vela/community#702 * test(compiler): handle escape sequences * chore: use latest go-vela/types --------- Co-authored-by: Jordan Brockopp <jordan.brockopp@target.com> Co-authored-by: Jacob Floyd <cognifloyd@gmail.com> Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com> Co-authored-by: David May <49894298+wass3rw3rk@users.noreply.github.com> Co-authored-by: NickHackman <Nick.Hackman@target.com>
3 participants
This demonstrates #26:
Once get confirmation on behavior expected can update.