Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to show all log lines #287

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Add button to show all log lines #287

merged 1 commit into from
Aug 20, 2019

Conversation

dramich
Copy link
Contributor

@dramich dramich commented May 3, 2019

Currently with large logs it takes many clicks to be able to see the
entire log file or the top of the log file.

This button displays all log lines with one click.

Currently with large logs it takes many clicks to be able to see the
entire log file or the top of the log file.

This button displays all log lines with one click.
@bradrydzewski
Copy link
Member

thanks, can you also provide a screenshot so that design team can review and provide feedback?

@dramich
Copy link
Contributor Author

dramich commented May 3, 2019

Yes, see below:
Screen Shot 2019-05-03 at 11 28 06 AM

@bradrydzewski
Copy link
Member

thanks! cc @lnikell

@lnikell
Copy link
Contributor

lnikell commented May 5, 2019

@bradrydzewski two blocks with show logs will be too much, I would prefer to put it near with download button or think about some option to keep show all and 250 in one line. We will come up with some solution.

@stevecrozz
Copy link

Chiming in with another idea, it might be cool to do something similar to what slack does and anchor you to the bottom when you first visit a room (or a stage in our case) but automatically load more as you scroll back.

@bradrydzewski
Copy link
Member

bradrydzewski commented May 19, 2019

The reason we do not display all logs by default is because logs greater than 2mb in size tend to lock up the browser. This was a significant issue in older version of drone and is the reason for the current user interaction, where you click a button to reveal more logs.

The reason for using a button is simplicity. We could implement more complex user interactions, but the complexity has a cost in terms of development effort and maintenance. The benefits of the complex interaction has to justify the cost. In this case, I think a simple button is sufficient.

Note that I do appreciate the suggestion, even though I prefer a different approach :)

@dramich
Copy link
Contributor Author

dramich commented May 31, 2019

@lnikell Any thoughts on this? I am happy to make the changes.

@bradrydzewski bradrydzewski merged commit 1685473 into drone:vue Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants