recreate sechedule pool on context refreshed #529
Conversation
| @@ -73,6 +73,9 @@ public synchronized void onContextRefreshedEvent(CustomContextRefreshedEvent eve | |||
| if (monitorFuture != null) { | |||
| monitorFuture.cancel(true); | |||
| } | |||
| if (MONITOR_EXECUTOR == null || MONITOR_EXECUTOR.isShutdown() || MONITOR_EXECUTOR.isTerminated()) { | |||
There was a problem hiding this comment.
这里优化感也不是何必要，除非改成是否开启监控的配置决定出是否实例化
There was a problem hiding this comment.
在多次执行onContextRefreshedEvent时这个判断是必要的，在dev tool classloader restart时,全局共享的MONITOR_EXECUTOR先会被shutdown,dtpmonitor创建新实例后重新执行onContextRefreshedEvent，这时复用老的MONITOR_EXECUTOR会发生RejectedExecutionException
简单来说dtpmonitor二次实例化会出现RejectedExecutionException
There was a problem hiding this comment.
在多次执行onContextRefreshedEvent时这个判断是必要的，在dev tool classloader restart时,全局共享的MONITOR_EXECUTOR先会被shutdown,dtpmonitor创建新实例后重新执行onContextRefreshedEvent，这时复用老的MONITOR_EXECUTOR会发生RejectedExecutionException
简单来说dtpmonitor二次实例化会出现RejectedExecutionException
确实，在SmartLifecycle中stop的时候shutdown了，确实如果restart要这么处理
There was a problem hiding this comment.
那就不只是DtpMonitor中静态线程池受影响，其他功能类中的也受影响吧。
fix issue #528