Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress upgrade to HTTP/2 and WebSockets #91

Closed
droe opened this issue Apr 23, 2015 · 1 comment
Closed

Suppress upgrade to HTTP/2 and WebSockets #91

droe opened this issue Apr 23, 2015 · 1 comment
Assignees
@droe
Labels
feature released
Milestone
0.5.2

Comments

@droe
Copy link
Owner

droe commented Apr 23, 2015

SSLsplit should suppress the Upgrade: request header (h2c, h2) in order to suppress upgrading a connection to HTTP/2. In theory this should only happen for HTTP, not HTTPS (NPN/ALPN are used for negotiation there), but in practice we may as well suppress the header in HTTPS too.

Note that websockets uses the Upgrade: header too; think about how to handle that.

See #89 for general HTTP/2 support.
@droe droe added the feature label Apr 23, 2015
@droe droe self-assigned this Apr 23, 2015
@droe droe added this to the 0.5.0 milestone Apr 23, 2015
@droe droe mentioned this issue Apr 23, 2015
Closed
@droe droe modified the milestones: 0.5.1, 0.5.0 Apr 23, 2015
@droe droe mentioned this issue Jul 23, 2016
Open
@droe droe modified the milestones: 0.5.1, 0.5.2 Jan 3, 2018
@droe droe removed their assignment Jan 3, 2018
@droe
Copy link
Owner Author

droe commented Feb 10, 2018

Since the rudimentary HTTP parsing currently implemented does not support WebSockets anyway, completely remove Upgrade: and corresponding Connection: upgrade headers. The latter was already suppressed as a side-effect of suppressing Connection: keepalive.

droe added a commit that referenced this issue Feb 10, 2018
@droe
Remove Upgrade: header to suppress WebSockets and HTTP/2
8e40678 
Issue:		#91
@droe droe closed this as completed Feb 10, 2018
@droe droe changed the title Suppress HTTP/2 negotiation without SSL/TLS (h2c) Suppress upgrade to HTTP/2 and WebSockets Feb 10, 2018
@droe droe self-assigned this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droe droe

Labels
feature released
Projects
None yet
Milestone
0.5.2
Development

No branches or pull requests
1 participant
@droe